Better handle transactions in pre-save #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoa
added a commit
to jsoa/django-easy-audit
that referenced
this pull request
May 18, 2020
8 tasks
|
Interesting fix. Looks good. Can you also add a test case? |
|
@jheld added test |
jheld
pushed a commit
that referenced
this pull request
Jul 22, 2020
* [-] CrudEvent object_id as a `CharField` * [-] Use `pk` instead of `id` in pre_save object lookup * [-] Fixes issue w/ post_delete / Adds delete test * [-] Adds updates from #141 PR * [-] Removes the need for an explicit query - Uses the internal `_state` object * [-] Adds `_state` compat test * [-] Removes sqlite3 test db
|
@Etenil can you check if the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-save hook makes the assumption that a PK that is set denotes a model update. In transactions it can happen that a PK is defined however the model isn't actually saved yet. The current code causes an error in these conditions.