Properly handle post delete in transactions #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschoettle
force-pushed
the
fix-post-delete
branch
from
58ca565
to
d6d9b19
Compare
mschoettle
changed the title
mschoettle
force-pushed
the
fix-post-delete
branch
from
bc0e684
to
3ced73b
Compare
If the model changes are committed in a transaction, at the time when the post delete signal is handled instance.pk returns None. Store the instance's ID beforehand so that it is available when creating the CRUDEvent.
mschoettle
force-pushed
the
fix-post-delete
branch
from
3ced73b
to
3ee9603
Compare
jheld
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the model changes are committed in a transaction, at the time when the post delete signal is handled instance.pk returns None.
This PR changes the logic such that the instance ID is retrieved before this happens, so that it is available when the event is logged and the CRUDEvent created.
Fixes #307