This repository has been archived by the owner on Dec 10, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wouldn't it be by far easier to implicitly mark all methods as |
@intrigus Yes, it would be easier. But I wanted two things:
|
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
============================================
+ Coverage 17.82% 17.85% +0.02%
Complexity 386 386
============================================
Files 312 314 +2
Lines 20747 20802 +55
Branches 4485 4493 +8
============================================
+ Hits 3699 3714 +15
- Misses 16369 16405 +36
- Partials 679 683 +4
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target JS to ES6 (you can always transpile it with a transpiler)
Use async/await pattern to enable support for synchronous I/O and threads
Partially implementation of #265 (but just for JS)