fix: preserve value when re-rendering #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console.log
statement that I assume wasn't meant to be committed to master.Issue Summary
I've found that if the component is re-rendered, the internal state remains but the fields are cleared. And if you try to enter new values, the old values reappear.
pin-field-error.mov
Fix
To fix this, the field component explicitly sets the
value
attribute on the<input />
element on render. This way, if the component is re-rendered, it will still display the internal state.