Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve value when re-rendering #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jgillick
Copy link

Issue Summary

I've found that if the component is re-rendered, the internal state remains but the fields are cleared. And if you try to enter new values, the old values reappear.

pin-field-error.mov

Fix

To fix this, the field component explicitly sets the value attribute on the <input /> element on render. This way, if the component is re-rendered, it will still display the internal state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant