Fix fetching of cluster metrics #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create configurable disable_cluster_metrics
Keksoj
force-pushed
the
fix-fetch-of-cluster-metrics
branch
from
4556238 to
6b53071
Compare
FlorentinDUBOIS
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster metrics are disabled by default, which is cumbersome. This PR introduces a configurable
enable_cluster_metricsthat istrueby default.On top of that, since introduction of Kawa, Sōzu would not register 4xx and 5xx HTTP statuses in worker and cluster metrics. For instance, Sōzu would respond with a default 404 but would NOT register this event in metrics. This is fixed here.