Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh attempt at chat design #294

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Fildrance
Copy link

@Fildrance Fildrance commented Aug 28, 2024

New attempt to change chat code. As it was in FSP attempt - with almost full rewok (of backend side). Most of key points have seams (as events) and main point is to change ways to determine chat channels as yaml!
This is raw draft - it can contain holes, so pls gief feedback. Pay close attention to yaml sample and workflow - they are most important parts.

@Fildrance Fildrance marked this pull request as ready for review September 3, 2024 20:30
Comment on lines 468 to 469
* These mutators are refined by adding "global" modifiers, such as a lizard person's trailing s's, a voice mask, and so on **<&#8203;3.2>** (additional event to collect mutators?)
* The system issues an chat message accent transformation event for person-specific accents **<&#8203;3.3>**.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the graph these are reversed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


| Condition | Technical description |Examples |
|:--- |:--- |:--- |
|Is cautious | Does not have SleepingComponent, DeafComponent (?)| Can only hear if is alive and awake.|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume you meant conscious?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, gonna fix it =w=

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@dffdff2423 dffdff2423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through this a bit and I can't see any obvious issues with this design technically, but I will give it another read later.

Admin chat should not be logged to replays by default. (it should be a cvar for servers that don't have public replays if those exist)

| Condition | Technical description | Description |
|:--- |:--- |:--- |
|Is cautious | Does not have StunnedComponent, MutedComponent or GhostComponent |Can only speak if alive and awake |
|Have organ to speark | Have VoiceComponent / HandsComponent / BorgChassisComponent | Can only speak while having mouth, can only emote while having hands, can only beep-boop whyle having chassis, can smile only when have mouth, etc.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"speark"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed typo, ty ty


| Condition | Technical description | Description |
|:--- |:--- |:--- |
|Is cautious | Does not have StunnedComponent, MutedComponent or GhostComponent |Can only speak if alive and awake |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you mean conscious, and not cautious here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@dffdff2423
Copy link
Contributor

This file is also not under the correct directory nor in the index.

@github-actions github-actions bot added the Design Related to design documentation for Space Station 14. label Sep 10, 2024
@Fildrance
Copy link
Author

I skimmed through this a bit and I can't see any obvious issues with this design technically, but I will give it another read later.

Admin chat should not be logged to replays by default. (it should be a cvar for servers that don't have public replays if those exist)

ty ty! new info for me - added to doc

@Fildrance
Copy link
Author

This file is also not under the correct directory nor in the index.

fixed ty, missed it after working too much time with the doc itself :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Related to design documentation for Space Station 14. English
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants