-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fresh attempt at chat design #294
base: master
Are you sure you want to change the base?
Fresh attempt at chat design #294
Conversation
src/en/space-station-14/chat.md
Outdated
* These mutators are refined by adding "global" modifiers, such as a lizard person's trailing s's, a voice mask, and so on **<​3.2>** (additional event to collect mutators?) | ||
* The system issues an chat message accent transformation event for person-specific accents **<​3.3>**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the graph these are reversed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
src/en/space-station-14/chat.md
Outdated
|
||
| Condition | Technical description |Examples | | ||
|:--- |:--- |:--- | | ||
|Is cautious | Does not have SleepingComponent, DeafComponent (?)| Can only hear if is alive and awake.| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i assume you meant conscious?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, gonna fix it =w=
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through this a bit and I can't see any obvious issues with this design technically, but I will give it another read later.
Admin chat should not be logged to replays by default. (it should be a cvar for servers that don't have public replays if those exist)
src/en/space-station-14/chat.md
Outdated
| Condition | Technical description | Description | | ||
|:--- |:--- |:--- | | ||
|Is cautious | Does not have StunnedComponent, MutedComponent or GhostComponent |Can only speak if alive and awake | | ||
|Have organ to speark | Have VoiceComponent / HandsComponent / BorgChassisComponent | Can only speak while having mouth, can only emote while having hands, can only beep-boop whyle having chassis, can smile only when have mouth, etc.| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"speark"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed typo, ty ty
src/en/space-station-14/chat.md
Outdated
|
||
| Condition | Technical description | Description | | ||
|:--- |:--- |:--- | | ||
|Is cautious | Does not have StunnedComponent, MutedComponent or GhostComponent |Can only speak if alive and awake | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you mean conscious, and not cautious here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
This file is also not under the correct directory nor in the index. |
ty ty! new info for me - added to doc |
fixed ty, missed it after working too much time with the doc itself :( |
New attempt to change chat code. As it was in FSP attempt - with almost full rewok (of backend side). Most of key points have seams (as events) and main point is to change ways to determine chat channels as yaml!
This is raw draft - it can contain holes, so pls gief feedback. Pay close attention to yaml sample and workflow - they are most important parts.