Skip to content

Commit

Permalink
apply :trollface:'s review
Browse files Browse the repository at this point in the history
  • Loading branch information
lzk228 committed Sep 20, 2024
1 parent 31747a0 commit 0aca706
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ public sealed partial class PickRandomPersonComponent : Component
/// <summary>
/// List of jobs, that won't be kill objectives
/// </summary>
[DataField, ViewVariables(VVAccess.ReadWrite)]
[DataField]
public List<ProtoId<JobPrototype>?> IgnoredJobs = new();
}
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,7 @@ private void OnPersonAssigned(EntityUid uid, PickRandomPersonComponent comp, ref
var allHumans = _mind.GetAliveHumansExcept(args.MindId);

// filter jobs that we don't want to be kill objectives
allHumans = allHumans
.Where(human => !_job.MindTryGetJobId(human, out var jobId) || !comp.IgnoredJobs.Contains(jobId))
.ToList();
allHumans.RemoveAll(human => !_job.MindTryGetJobId(human, out var jobId) || !comp.IgnoredJobs.Contains(jobId))

Check failure on line 61 in Content.Server/Objectives/Systems/KillPersonConditionSystem.cs

View workflow job for this annotation

GitHub Actions / Test Packaging

; expected

Check failure on line 61 in Content.Server/Objectives/Systems/KillPersonConditionSystem.cs

View workflow job for this annotation

GitHub Actions / Test Packaging

; expected

Check failure on line 61 in Content.Server/Objectives/Systems/KillPersonConditionSystem.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

; expected

Check failure on line 61 in Content.Server/Objectives/Systems/KillPersonConditionSystem.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

; expected

Check failure on line 61 in Content.Server/Objectives/Systems/KillPersonConditionSystem.cs

View workflow job for this annotation

GitHub Actions / YAML Linter

; expected

Check failure on line 61 in Content.Server/Objectives/Systems/KillPersonConditionSystem.cs

View workflow job for this annotation

GitHub Actions / YAML Linter

; expected

Check failure on line 61 in Content.Server/Objectives/Systems/KillPersonConditionSystem.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

; expected

Check failure on line 61 in Content.Server/Objectives/Systems/KillPersonConditionSystem.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

; expected

if (allHumans.Count == 0)
{
Expand Down

0 comments on commit 0aca706

Please sign in to comment.