Optimization!

space-wizards · Nov 10, 2024 · 2801ebe · 2801ebe
1 parent 0384373
commit 2801ebe
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/Content.Shared/Damage/Systems/DamageExamineSystem.cs b/Content.Shared/Damage/Systems/DamageExamineSystem.cs
@@ -61,15 +61,12 @@ private FormattedMessage GetDamageExamine(DamageSpecifier damageSpecifier, strin
         }
         else
         {
-            if (damageSpecifier.DamageDict.Count == 1)
+            if (damageSpecifier.GetTotal() == FixedPoint2.Zero && !damageSpecifier.AnyPositive())
             {
-                // May be simplified to using a foreach(Var x) despite being only one item
-                if(damageSpecifier.DamageDict.Values.GetEnumerator().Current == FixedPoint2.Zero)
-                {
-                    msg.AddMarkupOrThrow(Loc.GetString("damage-none"));
-                    return msg;
-                }
+                msg.AddMarkupOrThrow(Loc.GetString("damage-none"));
+                return msg;
             }
+
             msg.AddMarkupOrThrow(Loc.GetString("damage-examine-type", ("type", type)));
         }