Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PlaceableSurfaceComponent usages to PlaceableSurfaceSystem #28384

Merged

Conversation

ShadowCommander
Copy link
Member

About the PR

Moves PlaceableSurfaceComponent references to PlaceableSurfaceSystem

Why / Balance

Code cleanup

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

This check stops entities from being inserted into a storage entity
when it has a PlaceableSurfaceComponent.

The entity is instead placed on top of the entity like a table.
Copy link
Member

@AJCM-git AJCM-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self merge after this

@AJCM-git AJCM-git added the PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. label Jun 3, 2024
@metalgearsloth metalgearsloth merged commit 3fc9f96 into space-wizards:master Sep 19, 2024
9 checks passed
@ShadowCommander ShadowCommander deleted the placeable-system-updates branch October 18, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants