Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PlaceableSurfaceComponent usages to PlaceableSurfaceSystem #28384

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Move PlaceableSurfaceComponent usages to PlaceableSurfaceSystem #28384

merged 6 commits into from
Sep 19, 2024

Conversation

ShadowCommander
Copy link
Member

About the PR

Moves PlaceableSurfaceComponent references to PlaceableSurfaceSystem

Why / Balance

Code cleanup

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

@ShadowCommander
Move placeable check to PlaceableSurfaceSystem
e01d7e6 
This check stops entities from being inserted into a storage entity
when it has a PlaceableSurfaceComponent.

The entity is instead placed on top of the entity like a table.
@ShadowCommander
Move SetPlaceable to PlaceableSurfaceSystem
2bf124e
@ShadowCommander
Update to transform system and consolidate code
7a99a19
@ShadowCommander
Fix interaction with storage that has a placeable component
6491b3d
AJCM-git
AJCM-git approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@AJCM-git AJCM-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self merge after this

Content.Shared/Placeable/PlaceableSurfaceSystem.cs Show resolved Hide resolved
@AJCM-git AJCM-git added the PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. label Jun 3, 2024
@metalgearsloth metalgearsloth merged commit 3fc9f96 into space-wizards:master Sep 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJCM-git AJCM-git AJCM-git approved these changes

Assignees
No one assigned
Labels
PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShadowCommander @AJCM-git @metalgearsloth