-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Padded ItemStatus Text #29560
Padded ItemStatus Text #29560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this to StyleNano for ItemStatusNotHeld.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the same for ItemStatus and check if it works if you remove the Margin from the xaml.
If it doesn't work, then just use the margin in the xaml.
Also nice commits.
…us. Just using xaml for now.
When I tried StyleNano only, it worked for ItemStatusNotHeld but not for ItemStatus. Sticking with the XAML for now because it works for both. Thanks for pointing me towards StyleNano! This one's ready for review any time. |
It does work in StyleNano, but you have to convert the ItemStatus one from the old way to the new way. ItemStatusNotHeld is using the new way. |
I don't know how to suggest this as a change, but they want you to do this in StyleNano.cs
|
About the PR
Adds a little margin to the ItemStatus text. Fixes #27756.
Why / Balance
Literally unplayable, WizDen plz fixMinor graphical fix.
Technical details
"No held item" can have a little margin as a treat.
Media
(Showcase not needed. Before/After included for ease of review.)
Before:
After:
Breaking changes
Changelog
n/a