Traitor activation fix for missing PDA #30359

Errant-4 · 2024-07-25T20:56:57Z

About the PR

Traitors who "activate" without a PDA will now correctly get the codewords, the audio notification, and get an installed Uplink Implant. The cost is taken from their starting TC. This is objectively a worse situation than actually having purchased this implant from a normal uplink, but is still far better than missing out on all your TC and not knowing the code words

Why / Balance

Fixes #27444
Fixes #28138
Fixes #27928
Probably makes #28637 easier

Media

I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑 Errant

fix: Players becoming Traitor without a PDA now correctly get the text and audio notifications, and the code words. They are also given an Uplink Implant, with the price taken from their starting TC.

… shame

slarticodefast · 2024-07-25T22:22:49Z

What the heck, I have just written exactly the same thing. Let me see how you solved it, lol.

slarticodefast

Now that MakeTraitor no longer fails halfway through syndicate monkeys and reinforcements will get traitor objectives and an uplink as well. At least that happened for me. The giveUplink parameter in MakeTraitor and the GiveUplink and GiveObjectives datafields in the AutoTraitorComponent are currently completely unused. The only thing preventing the objectives was the missing pda.

Content.Server/Traitor/Uplink/UplinkSystem.cs

Resources/Locale/en-US/game-ticking/game-presets/preset-traitor.ftl

Errant-4 · 2024-07-26T08:31:42Z

Wow, good catch thanks. This would have been FAR WORSE than it initially sounds, because it's a potential infinite loop.
Get traitor, buy 2 monkeys and 8 TC worth of your own weapons, tell the 2 monkeys to buy 2 monkeys each and 6 TC worth of their own weapons, tell the next 4 monkeys to buy 8 more monkeys, this is only limited by the number of available Ghosts lol

lzk228 · 2024-07-26T08:36:02Z

how many metagamers will use it for free uplink implant?

slarticodefast · 2024-07-26T08:45:49Z

how many metagamers will use it for free uplink implant?

It is not free, it deducts the cost of the implant from your starting TC, so it is like a forced purchase.

Content.Server/Traitor/Uplink/UplinkSystem.cs

Errant-4 · 2024-07-27T11:47:30Z

So I went and made the TelecrystalBalance FixedPoint2 everywhere for consistency. This does not currently do anything because TC are only given in values that match exact integers, TC only exists in whole units in the world, and all prices are integer values even though the data type is FixedPoint2.

But now it is more consistent internally and it is theoretically possible to offer amazing discounted wares at 3.79 TC

(Actually, I think that was probably already possible anyway. But it just BOTHERED ME that we are passing integers into FixedPoint2 variables)

…raitorRuleComponent, no pda for reinforcements

Errant-4 · 2024-07-28T21:30:45Z

I added new datafields to TraitorRuleComponent that can turn off traitor stuff that we don't want on reinforcements (codewords*, uplink, briefing), and created a new traitor profile with just those being different, to be used on AutoTraitorComponent (which now passes the profile to be used to the system, rather than those 3 variables which weren't even used anywhere)

actually it might be nice to give codewords to reinforcements, but there is a technical issue with that now, since Reinforcements are a different traitor profile now, they get their own randomised set of codewords so they are "incompatible"

slarticodefast · 2024-08-01T11:00:47Z

Probably fixes #27444 ?
The traitor status was cancelled due to the missing pda.

github-actions · 2024-08-05T04:56:26Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-08-07T09:35:04Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Co-authored-by: slarticodefast <[email protected]>

github-actions · 2024-10-09T12:23:51Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

slarticodefast · 2024-10-18T12:37:20Z

I did some minor cleanup, but otherwise the code looks good to me.
One last bug I found while testing: Reinforcement agents and kobolts/monkeys now get their own objectives (was that a thing before or did it simply fail to produce them because of the missing pda?). That should probably be another setting in the traitor rule.
Edit: this seems to be a problem on master already, so that fix is out of scope

* Implant the uplink if no PDA is found * comments * tidy up loose ends * Whoops usually I start with the namespace, how did I forget it, shame shame * Consistent data type for starting TC balance, misc changes * Implant briefing, guidebook * Update AutoTraitor, add uplink, codeword and briefing parameters to TraitorRuleComponent, no pda for reinforcements * engine 5c0ce43 * pass pda to AddUplink Co-authored-by: slarticodefast <[email protected]> * nicer string handling Co-authored-by: slarticodefast <[email protected]> * case typo 1 Co-authored-by: slarticodefast <[email protected]> * case typo 2 Co-authored-by: slarticodefast <[email protected]> * case typo 3 Co-authored-by: slarticodefast <[email protected]> * minor layout changes * removed redundant implant check * minor cleanup --------- Co-authored-by: slarticodefast <[email protected]>

Errant-4 added 4 commits July 25, 2024 17:54

Implant the uplink if no PDA is found

5b31ad1

comments

2849d8b

tidy up loose ends

aa00d02

Whoops usually I start with the namespace, how did I forget it, shame…

817db07

… shame

Errant-4 requested a review from EmoGarbage404 as a code owner July 25, 2024 20:56

github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Jul 25, 2024

slarticodefast reviewed Jul 25, 2024

View reviewed changes

Content.Server/Traitor/Uplink/UplinkSystem.cs Outdated Show resolved Hide resolved

Resources/Locale/en-US/game-ticking/game-presets/preset-traitor.ftl Outdated Show resolved Hide resolved

slarticodefast reviewed Jul 26, 2024

View reviewed changes

Content.Server/Traitor/Uplink/UplinkSystem.cs Outdated Show resolved Hide resolved

Errant-4 added 2 commits July 27, 2024 09:50

Consistent data type for starting TC balance, misc changes

e7150ee

Implant briefing, guidebook

68ee95f

Update AutoTraitor, add uplink, codeword and briefing parameters to T…

df1ab5c

…raitorRuleComponent, no pda for reinforcements

Errant-4 requested a review from DrSmugleaf as a code owner July 28, 2024 21:24

Errant-4 mentioned this pull request Jul 30, 2024

Restore the longer traitor briefing message #30404

Merged

1 task

github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Aug 5, 2024

Errant-4 added 2 commits August 6, 2024 08:26

Merge branch 'master' into uplink

7bee902

engine 5c0ce43

3cddbf1

github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Aug 6, 2024

github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Aug 7, 2024

Merge branch 'master' into uplink

74328bb

github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Aug 7, 2024

Merge branch 'master' into uplink

9b3eba2

slarticodefast added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Sep 19, 2024

Errant-4 and others added 8 commits September 19, 2024 16:04

Merge branch 'master' into uplink

74e9207

pass pda to AddUplink

0ed85ea

Co-authored-by: slarticodefast <[email protected]>

nicer string handling

e73c4de

Co-authored-by: slarticodefast <[email protected]>

case typo 1

1712a5b

Co-authored-by: slarticodefast <[email protected]>

case typo 2

1301d94

Co-authored-by: slarticodefast <[email protected]>

case typo 3

3ecdb73

Co-authored-by: slarticodefast <[email protected]>

minor layout changes

81738b6

removed redundant implant check

67cafab

slarticodefast added the Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. label Sep 19, 2024

slarticodefast self-assigned this Oct 4, 2024

github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Oct 9, 2024

Errant-4 added 2 commits October 10, 2024 20:24

Merge branch 'master' into uplink

03790a4

Merge branch 'master' into uplink

0f8e2ae

github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Oct 10, 2024

Errant-4 requested a review from slarticodefast October 13, 2024 07:21

github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Oct 13, 2024

slarticodefast added 2 commits October 16, 2024 18:34

Merge branch 'master' into pr/30359

a6b6ae2

minor cleanup

3a6f179

slarticodefast approved these changes Oct 18, 2024

View reviewed changes

slarticodefast merged commit 23e4f81 into space-wizards:master Oct 18, 2024
11 checks passed

Errant-4 mentioned this pull request Oct 18, 2024

HOTFIX Traitor activation fix for missing PDA (#30359) #32880

Closed

slarticodefast mentioned this pull request Oct 18, 2024

The datafields on AutoTraitorComponent are broken #28093

Closed

lzk228 mentioned this pull request Oct 30, 2024

Translate Upstream #2718 space-syndicate/space-station-14#2719

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Traitor activation fix for missing PDA #30359

Traitor activation fix for missing PDA #30359

Errant-4 commented Jul 25, 2024 •

edited

Loading

slarticodefast commented Jul 25, 2024

slarticodefast left a comment

Errant-4 commented Jul 26, 2024

lzk228 commented Jul 26, 2024

slarticodefast commented Jul 26, 2024 •

edited

Loading

Errant-4 commented Jul 27, 2024 •

edited

Loading

Errant-4 commented Jul 28, 2024 •

edited

Loading

slarticodefast commented Aug 1, 2024

github-actions bot commented Aug 5, 2024

github-actions bot commented Aug 7, 2024

github-actions bot commented Oct 9, 2024

slarticodefast commented Oct 18, 2024 •

edited

Loading

Traitor activation fix for missing PDA #30359

Traitor activation fix for missing PDA #30359

Conversation

Errant-4 commented Jul 25, 2024 • edited Loading

About the PR

Why / Balance

Media

slarticodefast commented Jul 25, 2024

slarticodefast left a comment

Choose a reason for hiding this comment

Errant-4 commented Jul 26, 2024

lzk228 commented Jul 26, 2024

slarticodefast commented Jul 26, 2024 • edited Loading

Errant-4 commented Jul 27, 2024 • edited Loading

Errant-4 commented Jul 28, 2024 • edited Loading

slarticodefast commented Aug 1, 2024

github-actions bot commented Aug 5, 2024

github-actions bot commented Aug 7, 2024

github-actions bot commented Oct 9, 2024

slarticodefast commented Oct 18, 2024 • edited Loading

Errant-4 commented Jul 25, 2024 •

edited

Loading

slarticodefast commented Jul 26, 2024 •

edited

Loading

Errant-4 commented Jul 27, 2024 •

edited

Loading

Errant-4 commented Jul 28, 2024 •

edited

Loading

slarticodefast commented Oct 18, 2024 •

edited

Loading