Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cyborg Loadouts #30406

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Cyborg Loadouts #30406

wants to merge 17 commits into from
+372 −51

Conversation

Doctor-Cpu
Copy link
Contributor

About the PR

Round start cyborgs can now select which chassis they wish to start the round as.

Why / Balance

Saves pestering science and see no reason to restrict to generic cyborgs.

Technical details

Loadouts can now specify a prototype to override the players.

Media

borg.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

N/A

Changelog

🆑

  • add: Cyborgs can now select their round start chassis in their loadouts.

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Jul 27, 2024
@lzk228
Copy link
Contributor

lzk228 commented Jul 27, 2024

yes please

@UbaserB
Copy link
Member

UbaserB commented Jul 27, 2024

based!!

@SoulFN
Copy link
Contributor

SoulFN commented Jul 27, 2024

Did all chassis have the tool module? Or they are different for every chaises? Like medical chassis starts with treatment module

@Brandon-Huu
Copy link
Contributor

Was not giving the borgs their respective job modules a design decision?

@Doctor-Cpu
Copy link
Contributor Author

Was not giving the borgs their respective job modules a design decision?

I just decided to keep them in line with the generic cyborg.
Does seem silly now that it's been pointed out so I'll add the respective modules available round start.

@Djungelskog2
Copy link

are you also working on borg names? or any system that can be used for borgs/mimes/clowns?

@Doctor-Cpu
Copy link
Contributor Author

are you also working on borg names? or any system that can be used for borgs/mimes/clowns?

Can look at that again. I would split the pr however.

@CatBackGround
Copy link

Oh... Please add.

@bruhmogus
Copy link

i beg that this is added

@slarticodefast
Copy link
Member

Fixes #22807

@metalgearsloth metalgearsloth added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Aug 9, 2024
@UbaserB
Copy link
Member

UbaserB commented Aug 9, 2024

Is it possible to make it so that you spawn with a module (of whichever borg chassis you are), like the very defaults

@Doctor-Cpu
Copy link
Contributor Author

Is it possible to make it so that you spawn with a module (of whichever borg chassis you are), like the very defaults

Every chassis gets a tools module and any modules that fit the chassis that are available round start.
eg. Medical chassis gets tools and the treatment module

@UbaserB
Copy link
Member

UbaserB commented Aug 9, 2024

Every chassis gets a tools module and any modules that fit the chassis that are available round start. eg. Medical chassis gets tools and the treatment module

oh perfect!

@Doctor-Cpu
Copy link
Contributor Author

image
image
Clothing loadouts should work now as well.

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Aug 15, 2024
@deathride58 deathride58 added the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Aug 19, 2024
@metalgearsloth metalgearsloth added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Aug 23, 2024
@Chubbicous Chubbicous mentioned this pull request Aug 27, 2024
Open
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Aug 28, 2024
@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 2, 2024
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Sep 2, 2024
@Doctor-Cpu
Copy link
Contributor Author

not sure why tests fail
ninja and vox internals work fine

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@DandiIion
Copy link

Still workin on this? I pray for your success. 🙏

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

@metalgearsloth metalgearsloth Awaiting requested review from metalgearsloth

Assignees
No one assigned
Labels
Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Needs Review This PR requires new reviews before it can be merged. Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.