Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L6 Fits in the Suit Storage Slot #30525

Merged
merged 2 commits into from
Sep 23, 2024
Merged

L6 Fits in the Suit Storage Slot #30525

merged 2 commits into from
Sep 23, 2024
+7 −0

Conversation

Cojoke-dot
Copy link
Contributor

@Cojoke-dot Cojoke-dot commented Jul 31, 2024 •
edited
Loading

About the PR

Lets the l6 fit in the suit storage slot

Why / Balance

CONSISTENCY!!! :)

Technical details

Do it like how other guns do it

Media

image

Screenshot 2024-09-22 152344

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: L6 Saw now fits in the suit slot
  • tweak: L6 Saw is now a 5x4 item

@github-actions github-actions bot added No C# For things that don't need code. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. labels Jul 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024 •
edited
Loading

RSI Diff Bot; head commit 70248a4 merging into f264da8
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Weapons/Guns/LMGs/l6.rsi

State Old New Status
equipped-SUITSTORAGE Added

Edit: diff updated after 70248a4

@Dutch-VanDerLinde
Copy link
Contributor

pretty sure this is for balancing

@Cojoke-dot
Copy link
Contributor Author

pretty sure this is for balancing

Meh, other huge items and most guns can be stored in the slot. My mind went to the mini jet pack for a size comparison if other stuff that size could fit in the slot. An extra couple bag slots could be good sure, but nukies are the main user of the weapon and they already have the space for everything they need. Maybe it if you have something huge on your back, it blocks your bag from opening :trollface:

@ps3moira
Copy link
Contributor

ps3moira commented Aug 1, 2024

Seems intentional if it's a massive machine gun tbf

@UbaserB UbaserB added the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Sep 4, 2024
UbaserB
UbaserB requested changes Sep 22, 2024
View reviewed changes
Copy link
Member

@UbaserB UbaserB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it 5x4 in size as well?

@UbaserB UbaserB added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Sep 22, 2024
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Sep 22, 2024
@UbaserB
Copy link
Member

UbaserB commented Sep 23, 2024

Thanks for your contribution.

@UbaserB UbaserB merged commit 3d2aadd into space-wizards:master Sep 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UbaserB UbaserB UbaserB approved these changes

Assignees
No one assigned
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# For things that don't need code. Status: Needs Review This PR requires new reviews before it can be merged. Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cojoke-dot @Dutch-VanDerLinde @ps3moira @UbaserB