-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rejig LogStringHandler #30706
Open
ElectroJr
wants to merge
8
commits into
space-wizards:master
Choose a base branch
from
ElectroJr:admin-log2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rejig LogStringHandler #30706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectroJr
requested review from
Partmedia,
DrSmugleaf and
Chief-Engineer
as code owners
August 6, 2024 11:36
github-actions
bot
added
Status: Needs Review
This PR requires new reviews before it can be merged.
labels
Aug 6, 2024
ElectroJr
added
the
Needs Engine PR
This PR is awaiting engine changes that should be merged before this.
label
Aug 7, 2024
github-actions
bot
added
the
Merge Conflict
This PR currently has conflicts that need to be addressed.
label
Sep 2, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ElectroJr
added
Needs #codebase-changes
This PR has changes that should be announced in the #codebase-changes discord channel.
and removed
Needs Engine PR
This PR is awaiting engine changes that should be merged before this.
labels
Sep 6, 2024
github-actions
bot
removed
the
Merge Conflict
This PR currently has conflicts that need to be addressed.
label
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs #codebase-changes
This PR has changes that should be announced in the #codebase-changes discord channel.
Status: Needs Review
This PR requires new reviews before it can be merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks parts of admin logging and
LogStringHandler
, both to make it slightly nicer to use, and to remove some unnecessary component queries. The main change is that a lot of the processing that was happening inAdminLogManager.ToJson()
is now done in the string interpolation handler (LogStringHandler
).Also fixes #31531
Changes:
ToPrettyString()
when given an entity. I.e.,$"{ToPrettyString(user):user} interacted with {ToPrettyString(target):target}"
can now be replaced with$"{user} interacted with {target}"
.NetEntity
and objects that implementIAsType<EntityUid>
as entities. This means thatEntity<T1,T2..>
should be recognized as entities once they are given the IAsType interface (which is included in Toolshed Rejig RobustToolbox#5455)SerializableEntityCoordinates
and replaced the json converter with something that just directly usesEntityCoordinates
. I'm not really sure why this struct even existed.SerializablePlayer
struct was moved from a sever-side to a shared namespace