Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a directory to station maps #31156

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

TGRCdev
Copy link
Contributor

@TGRCdev TGRCdev commented Aug 18, 2024

About the PR

This PR adds a directory to the station map UI, with buttons that center the map screen on the selected beacon. This is ported from the downstream fork Imp Station 14.

Why / Balance

Big stations are a mess to navigate. Trying to pick out a specific area on the map is difficult, if it even exists at all (some maps don't mark Cryosleep!).

This will make playing new maps far less difficult, as you can easily see what is available, and search for specific areas.

Technical details

When the UI opens, it will loop through all the enabled beacons on the map and create buttons that will recenter onto the beacon's offset when clicked. This menu does not adjust if beacons are removed/renamed/recolored, but it does not cause any errors if this happens.

Buttons in the menu are first sorted by converting the color to a 4 byte integer and sorting that, effectively "grouping" beacons with similar colors together. If beacons are the same color, they are then sorted alphabetically.

Media

map-directory.mp4

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 TGRCDev

  • add: Station maps now have a directory for finding specific departments and areas.

@github-actions github-actions bot added the Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design label Aug 18, 2024
@TGRCdev TGRCdev changed the title Added directory to station maps Added a directory to station maps Aug 18, 2024
@Emisse
Copy link
Contributor

Emisse commented Aug 19, 2024

works fine but linq scares me

@TGRCdev
Copy link
Contributor Author

TGRCdev commented Aug 19, 2024

The Linq statement only runs once when the station map UI opens to group and sort the beacons, so it shouldn't be a problem performance/efficiency-wise.

@UbaserB UbaserB added the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Aug 25, 2024
@TGRCdev
Copy link
Contributor Author

TGRCdev commented Sep 14, 2024

The Build & Test step failed due to an unrelated error in the integration tests.

@SlamBamActionman
Copy link
Member

Heya, sorry for the delay in replies from maintainers. We're overall very positive to this, but there are AX concerns in regards to readability with colored text over the blue buttons. Would it be possible to implement the departmental color in some other way?

One suggestion was to color the end of the button, like folder tabs:
image

@TGRCdev
Copy link
Contributor Author

TGRCdev commented Sep 20, 2024

AX is a good point! I borrowed some code from the ReagentDispenser window, and I think it is much more readable this way.

image

I gotta rework the search code a bit, and then I'll have a new commit soon.

@SlamBamActionman SlamBamActionman merged commit d32c42f into space-wizards:master Sep 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants