Move OnGhostAttempt to GhostSystem #31445

Winkarst-cpu · 2024-08-25T22:45:02Z

About the PR

Moved OnGhostAttempt to GhostSystem.

Why / Balance

Resolves #4410.

Technical details

Media

Requirements

I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

OnGhostAttempt method was moved to the GhostSystem and might break something downstream.

Plykiya · 2024-08-25T23:07:14Z

thank you, I was really confused why it was attached to game ticker in the first place

slarticodefast

Since other systems use this function, please add the change to the Breaking Changes category in your PR description. Downstream forks might need to adjust the changed namespace.

Content.Server/Bed/Cryostorage/CryostorageSystem.cs

slarticodefast · 2024-08-26T12:16:51Z

Thanks for the cleanup!

@deltanedas

* Update Credits (space-wizards#31409) Co-authored-by: PJBot <[email protected]> * Replace obsolete code in GasPortableSystem (space-wizards#31407) * Change `Resave` Permission Requirement to Host (space-wizards#31397) ChangePermissionFlagToHost * Automatic changelog update * Remove client state from server AirAlarmComponent (space-wizards#31236) * Remove client state from server AirAlarmComponent Send information for all connected devices, not just the ones for the current tab, as attempting to limit this breaks multiple users viewing the same UI. Fixes space-wizards#12842 * Send device data as a list, rather than a dictionary --------- Co-authored-by: Eoin Mcloughlin <[email protected]> * Fix ChemVend jugs again (space-wizards#31398) This re-introduces the dummy entity naming code, originally introduced in space-wizards#29178 and randomly removed by space-wizards#30064 with no technical justification given. Fixes space-wizards#31373 * Automatic changelog update * Fix dungeon spawn + ftl overlap (space-wizards#31413) * Fix dungeon spawn + ftl overlap * Better fixes * Automatic changelog update * Fix firelockedge rotation (space-wizards#31371) save * Automatic changelog update * Update Oasis (space-wizards#31415) * Cameras and junk * I forgot to clear my multitool * Automatic changelog update * marathon update (space-wizards#31421) * Give sec cadets jackboots instead of combat boots (space-wizards#31419) give cadets jackboots * Automatic changelog update * meta update (space-wizards#31423) * Adds the Head of Greytide stamp (space-wizards#30189) suggested changes from discord discussion, sprite change, add to refactored loot table * Automatic changelog update * Verb tweaks (space-wizards#31309) * Verb tweaks Remove the LOS check because this is already done above in CanExamine. * Fix outlines * import * Add ContainerComp (space-wizards#31311) Applies EntProtoId changes upon insertion / removal from container. Can also be useful for borgs / mechs / vehicles in future but atm I just used it for AI. * Blueprints (space-wizards#31138) * Blueprints * Update tables_loot.yml * doink * mark as required * Automatic changelog update * decouple ItemToggle from PowerCellDraw (space-wizards#31392) * remove ItemToggle from PowerCellDraw query * add EntityQuery for resolves, make them all optional * move integration to ToggleCellDraw * add ToggleCellDraw to almost every PowerCellDraw prototype *

*

* let it disable on mapinit * set update time on mapinit, make borg power logic consistent now *

--------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Automatic changelog update * Power stuff (space-wizards#31314) * Power stuff - Add shared IsPowered - Add shared ResolveApc - Move PowerChangedEvent to shared for now - Add SlimPoweredLight that actually functions how you'd expect a PoweredLight to function it id didn't have a bunch of bloat on it. * big update * boing * ItemToggle + slots stuff (space-wizards#31312) * ItemToggle + slots stuff - Add component for itemslot locks to match LockComponent (surprised this didn't exist). - Add thing for pointlight to match itemtoggle. In future should be used for PDAs and stuff but need to fix some other stuff first. * Also this * grill * Run actions on press (space-wizards#31191) I know UI generallys want to do stuff on key-up not key-down. With that being said the delay on release for these is noticeable. e.g. ActivateInWorld / UseInHand / any in-world interactions are on-press. This is especially noticeable if you have the same event on action + verb. * Automatic changelog update * Action stuff (space-wizards#31305) * Action stuff - Cleanup some event stuff - Avoid dirtying entity unnecessarily - Add ActionGrant as an easy way to apply / remove actions via compregistry. * Fix merge * Update submodule to 231.0.0 (space-wizards#31430) * Weather fix (space-wizards#30857) * weather fix * localize errors * ContainerComp fix (space-wizards#31434) Forgot to push these ones on the branch. * togglelight updates (space-wizards#31435) Missed in the green checkmark sea * Increase (SUPER)PACMAN ramp rate/tolerance (space-wizards#31403) All PACMANs used to use the same ramping parameters, this meant a SUPERPACMAN (50 kW) took literally a 100 seconds to get up to its full output level. Ouch. PACMAN has been raised to 5000 W/s with 1500 W tolerance, SUPERPACMAN to 7500 W/s with 2500 W tolerance * Automatic changelog update * Make space scanning T1 technology (space-wizards#31321) make space scanning and mass scanner t1 tech * Automatic changelog update * Add a bool to disable buckling on InteractHand (space-wizards#30001) * Automatic changelog update * fix(FieldGenerators): Don't show nonsense popup (space-wizards#30469) * . * bagel update (space-wizards#31440) * bagel update * fixgridatmos * qm office * sci cam fix * jesus christ so many routers * remove invalids * Fix-Resprite emote icons (space-wizards#31447) * Fix-Resprite emote icons * change scream * Moff cooking. Part one. (space-wizards#30668) * yml part * guidebook * commit * some fixes * a little * change * Automatic changelog update * Cog update (space-wizards#31458) made disposals less bad * Add BUI ctor tests (space-wizards#31463) 5 lines of eaten iocmanager.injectdependencies led to this. * Predict EmitSoundOnUIOpen (space-wizards#31464) * Predict EmitSoundOnUIOpen BUI prediction led to this moment. * unforky * Bots now make sound when they speak (space-wizards#31471) fixes 31454 * Automatic changelog update * Change the science radio channel color (space-wizards#31319) * Change the science radio channel color * This one looks better * Automatic changelog update * Move OnGhostAttempt to GhostSystem (space-wizards#31445) * Move OnGhostAttempt to GhostSystem * Remove unused dependencies and sort them * Fix energy sword visuals (space-wizards#31478) * Automatic changelog update * Replace obsolete code in shuttle systems. (space-wizards#31408) * Format DockingSystem.Shuttle * arrivals system * docking system * shuttle console system * emergency shuttle system * shuttle system * thruster system * Fix compile error --------- Co-authored-by: Pieter-Jan Briers <[email protected]> * Replaces small fans on most shuttles with directional fans. (space-wizards#31495) * Automatic changelog update * Replace obsolete functions in NPC systems (space-wizards#31448) * Make guidebook remember where you left off (space-wizards#31375) * Guidebook tracks last read entry * Persistent guidebook fixes * Persistent guidebook requested changes * Update Content.Client/UserInterface/Systems/Guidebook/GuidebookUIController.cs --------- Co-authored-by: Pieter-Jan Briers <[email protected]> * Automatic changelog update * Remove double-iteration from the mime wall code (space-wizards#31420) * Remove double-iteration from the mime wall code * Update * Update * fix method OnEntityEnter in DamageContactsSystem (space-wizards#31494) fix Co-authored-by: Dimastra <[email protected]> * Automatic changelog update * Make Gas Miners indestructable, anchorable, and pullable. (space-wizards#31370) * Make miner indestructable, and pullable. * Miners can't be unanchored. Only anchored. --------- Co-authored-by: JIPDawg <[email protected]> * Automatic changelog update * bagel update (space-wizards#31502) * Minor fixes to character profile editor save/reset buttons (space-wizards#31505) Merge SetDirty() with preview reload People were forgetting to SetDirty() when changing a property; move SetDirty() into preview reloading, since if the preview is being reloaded, some property has definitely changed anyway. Co-authored-by: Eoin Mcloughlin <[email protected]> * Centcom & FTLDestination cleanup (space-wizards#30226) * centcomm name and ftlcomp * networking microopstimization * go sleep. * map names and arrivals * Fix swapped around Safety Moth poster graphics (space-wizards#31507) * Automatic changelog update * Mark explosives as a contraband (space-wizards#31508) * Automatic changelog update * Mark the syndicate raid helmet as a Syndicate contraband (space-wizards#31512) * Automatic changelog update * Add title to multitool door-access-configuration window (space-wizards#31504) Fixes space-wizards#29923. Co-authored-by: Eoin Mcloughlin <[email protected]> * Restrict the explorer gas mask to cargo (space-wizards#31514) * Automatic changelog update * Fix stray pixel in officer beersky barsign (space-wizards#31517) * Scale text in admin player overlay (space-wizards#31503) * Scale text in admin player overlay Fixes space-wizards#30040 * Feedback from PR - get UI scale through root window --------- Co-authored-by: Eoin Mcloughlin <[email protected]> * New Health Analyzer UI (space-wizards#30834) * WIP: first prototype * Change text slightly * Allow names to wrap * Add label for the scan mode * Remove ugly text * Readd bleeding message * Update code * Allow for the Health Analyzer UI to grow vertically * Automatic changelog update * Disable Arrivals message for Cryosleep (space-wizards#30888) * Disable arrivals message for cryosleep late arrivals * Provide silent to PlayerSpawnCompleteEvent * Fix typo * Move message to event and into arrivals system * Automatic changelog update * Remove glibc from devshell (space-wizards#28842) * Automated whitelists (space-wizards#23985) * Beginnings of making the breadmemes jobs easier * stuff * stuff pt. 2 * Stuff pt.3 * Stuff I forgot last time * Basic whitelist Only people that are added to the whitelist with the addwhitelist command will be able to join. I call this the "legacy" whitelist * Remove always deny condition in favor of just breaking if playtime check fails * Change default whitelist Default whitelist is now the "legacy" whitelist. * localization * Admin check * minor spelling change * Fix build * Whitelist message * Fix vars not being datafield and spelling mistakes * Minor spelling mistake * Change config for salamander * Reviews and stuff * Add summaries * Fix whitelists * Forgot to add a datafield * Fixing stuff I guess * Reuse admin remarks to reduce load when connecting. * Update log messages to be verbose instead of debug * Reviews * whoops * Explain a bit more how whitelist checking works * Apply CE's review * Append Membership to Blacklist and Whitelist conditions * Fix review comments * Uncapitalize playerConnectionWhitelist, add to ignored client prototypes * Make note count field work * Fix cvar for thingy --------- Co-authored-by: Pieter-Jan Briers <[email protected]> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: PJBot <[email protected]> Co-authored-by: Mervill <[email protected]> Co-authored-by: PursuitInAshes <[email protected]> Co-authored-by: eoineoineoin <[email protected]> Co-authored-by: Eoin Mcloughlin <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: themias <[email protected]> Co-authored-by: IProduceWidgets <[email protected]> Co-authored-by: Emisse <[email protected]> Co-authored-by: PopGamer46 <[email protected]> Co-authored-by: ArtisticRoomba <[email protected]> Co-authored-by: Nemanja <[email protected]> Co-authored-by: deltanedas <[email protected]> Co-authored-by: Ed <[email protected]> Co-authored-by: Alzore <[email protected]> Co-authored-by: ShadowCommander <[email protected]> Co-authored-by: Brandon Hu <[email protected]> Co-authored-by: lzk <[email protected]> Co-authored-by: Spessmann <[email protected]> Co-authored-by: Moomoobeef <[email protected]> Co-authored-by: Winkarst <[email protected]> Co-authored-by: slarticodefast <[email protected]> Co-authored-by: QueerNB <[email protected]> Co-authored-by: 12rabbits <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: Dimastra <[email protected]> Co-authored-by: Dimastra <[email protected]> Co-authored-by: JIPDawg <[email protected]> Co-authored-by: JIPDawg <[email protected]> Co-authored-by: Saphire Lattice <[email protected]> Co-authored-by: Thomas <[email protected]> Co-authored-by: stellar-novas <[email protected]> Co-authored-by: Simon <[email protected]>

@deltanedas

* Automatic changelog update * Fix dungeon spawn + ftl overlap (space-wizards#31413) * Fix dungeon spawn + ftl overlap * Better fixes * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * Add ContainerComp (space-wizards#31311) Applies EntProtoId changes upon insertion / removal from container. Can also be useful for borgs / mechs / vehicles in future but atm I just used it for AI. * Automatic changelog update * Automatic changelog update * Power stuff (space-wizards#31314) * Power stuff - Add shared IsPowered - Add shared ResolveApc - Move PowerChangedEvent to shared for now - Add SlimPoweredLight that actually functions how you'd expect a PoweredLight to function it id didn't have a bunch of bloat on it. * big update * boing * Automatic changelog update * ContainerComp fix (space-wizards#31434) Forgot to push these ones on the branch. * Automatic changelog update * Automatic changelog update * Automatic changelog update * bagel update (space-wizards#31440) * bagel update * fixgridatmos * qm office * sci cam fix * jesus christ so many routers * remove invalids * Automatic changelog update * Automatic changelog update * Automatic changelog update * Move OnGhostAttempt to GhostSystem (space-wizards#31445) * Move OnGhostAttempt to GhostSystem * Remove unused dependencies and sort them * Automatic changelog update * Replace obsolete code in shuttle systems. (space-wizards#31408) * Format DockingSystem.Shuttle * arrivals system * docking system * shuttle console system * emergency shuttle system * shuttle system * thruster system * Fix compile error --------- Co-authored-by: Pieter-Jan Briers <[email protected]> * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * bagel update (space-wizards#31502) * Centcom & FTLDestination cleanup (space-wizards#30226) * centcomm name and ftlcomp * networking microopstimization * go sleep. * map names and arrivals * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * Make nukie plushie a non-contraband item (space-wizards#31516) Make nukie plushies a non-contraband item * Automatic changelog update * fix uncapitalized "S" in Salvage Specialist (space-wizards#31529) "Salvage specialist" to "Salvage Specialist"; all is right with the world * Make AKMS security restricted (space-wizards#31519) * Automatic changelog update * bagel update (space-wizards#31535) * Update submodule to 231.1.0 (space-wizards#31536) * Station AI (space-wizards#30944) * Station AI overlay * implement * Bunch of ports * Fix a heap of bugs and basic scouting * helldivers * Shuffle interactions a bit * navmap stuff * Revert "navmap stuff" This reverts commit d1f89dd. * AI wires implemented * Fix examines * Optimise the overlay significantly * Back to old static * BUI radial working * lots of work * Saving work * thanks fork * alright * pc * AI upload console * AI upload * stuff * Fix copy-paste shitcode * AI actions * navmap work * Fixes * first impressions * a * reh * Revert "navmap work" This reverts commit 6f63fea. # Conflicts: # Content.Client/Silicons/StationAi/StationAiOverlay.cs * OD * radar * weh * Fix examines * scoop mine eyes * fixes * reh * Optimise * Final round of optimisations * Fixes * fixes * Bagel station ai (space-wizards#31537) * real * AI * proto fix * Fix PostMapInit tests not considering job containerspawns (space-wizards#31538) * Fix PostMapInit tests nto considering job containerspawns * fix * AI whitelist fix (space-wizards#31542) * cog update (space-wizards#31540) updooted cog * AI radio fix (space-wizards#31547) Love to see it * Storage BUI bandaid (space-wizards#31506) grug storageuicontroller * Fix puddle context menu (space-wizards#31555) * Update AI holo sprite to camera (space-wizards#31558) Update AI camera to 13 default Holo was a placeholder. This is better in the interim. * Add AI warp points (space-wizards#31559) * Automatic changelog update * Fix AI being ejectable (space-wizards#31561) * Automatic changelog update * Fix whitelist (space-wizards#31563) * Automatic changelog update * bagel update (space-wizards#31562) * bagel update * ore processor cargo * Add some more stuff to AI whitelist (space-wizards#31564) * Add some more stuff to AI whitelist * by the nine * Automatic changelog update * Meta - Med disposals and chem room extra pipe fix (space-wizards#31467) Delete extra pipe & fix disposals junction * bagel hotfix (space-wizards#31566) bagel update * update AI job icon to 8x8 (space-wizards#31565) icon and meta.json * Automatic changelog update * Update ClothingSpeedModifierSystem.cs (space-wizards#29994) * TryGetContainerContainer * Math * Changed AddMarkup to AddMarkupOrThrow * Better math * engine version * engine version * Add black suspenders (space-wizards#29055) * Black suspenders * fix * fix linter * Automatic changelog update * recolor riot helmet (space-wizards#31530) * recolor riot helmet resolves space-wizards#31256 match riot helmet to default security helmet * further color tweaks for consistency; update meta.json Tweaked equipped sprites to more closely match the security helmet. * Automatic changelog update * added wide-spectrum anomaly locator to anomaly cyborg module (space-wizards#31427) added wide-spectrum anomaly locator to anomaly borg module * Automatic changelog update * Add Robust.Xaml.csproj to the solution (space-wizards#31573) * add construction for carp statue (space-wizards#31261) * separate eyes and teeth * make it buildable and make fixture less abusable * norot --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Automatic changelog update * fix spelling error silicon jobs (space-wizards#31581) Update department.ftl * Fixes shuttles not being able to FTL onto/near station (space-wizards#31569) fixes FTL * Automatic changelog update * Merge Upstream * Merge Upstream * fix wizden bagel * bagel * b a g e l --------- Co-authored-by: PJBot <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Emisse <[email protected]> Co-authored-by: Winkarst <[email protected]> Co-authored-by: Mervill <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: IProduceWidgets <[email protected]> Co-authored-by: saintmuntzer <[email protected]> Co-authored-by: Spessmann <[email protected]> Co-authored-by: JustCone <[email protected]> Co-authored-by: lunarcomets <[email protected]> Co-authored-by: Errant <[email protected]> Co-authored-by: lzk <[email protected]> Co-authored-by: coolboy911 <[email protected]> Co-authored-by: deltanedas <[email protected]> Co-authored-by: PopGamer46 <[email protected]>

* Automatic changelog update * Fix dungeon spawn + ftl overlap (space-wizards#31413) * Fix dungeon spawn + ftl overlap * Better fixes * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * meta update (space-wizards#31423) * Automatic changelog update * Add ContainerComp (space-wizards#31311) Applies EntProtoId changes upon insertion / removal from container. Can also be useful for borgs / mechs / vehicles in future but atm I just used it for AI. * Automatic changelog update * Automatic changelog update * Power stuff (space-wizards#31314) * Power stuff - Add shared IsPowered - Add shared ResolveApc - Move PowerChangedEvent to shared for now - Add SlimPoweredLight that actually functions how you'd expect a PoweredLight to function it id didn't have a bunch of bloat on it. * big update * boing * Automatic changelog update * ContainerComp fix (space-wizards#31434) Forgot to push these ones on the branch. * Automatic changelog update * Automatic changelog update * Automatic changelog update * bagel update (space-wizards#31440) * bagel update * fixgridatmos * qm office * sci cam fix * jesus christ so many routers * remove invalids * Automatic changelog update * Cog update (space-wizards#31458) made disposals less bad * Automatic changelog update * Automatic changelog update * Move OnGhostAttempt to GhostSystem (space-wizards#31445) * Move OnGhostAttempt to GhostSystem * Remove unused dependencies and sort them * Automatic changelog update * Replace obsolete code in shuttle systems. (space-wizards#31408) * Format DockingSystem.Shuttle * arrivals system * docking system * shuttle console system * emergency shuttle system * shuttle system * thruster system * Fix compile error --------- Co-authored-by: Pieter-Jan Briers <[email protected]> * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * bagel update (space-wizards#31502) * Centcom & FTLDestination cleanup (space-wizards#30226) * centcomm name and ftlcomp * networking microopstimization * go sleep. * map names and arrivals * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automated whitelists (space-wizards#23985) * Beginnings of making the breadmemes jobs easier * stuff * stuff pt. 2 * Stuff pt.3 * Stuff I forgot last time * Basic whitelist Only people that are added to the whitelist with the addwhitelist command will be able to join. I call this the "legacy" whitelist * Remove always deny condition in favor of just breaking if playtime check fails * Change default whitelist Default whitelist is now the "legacy" whitelist. * localization * Admin check * minor spelling change * Fix build * Whitelist message * Fix vars not being datafield and spelling mistakes * Minor spelling mistake * Change config for salamander * Reviews and stuff * Add summaries * Fix whitelists * Forgot to add a datafield * Fixing stuff I guess * Reuse admin remarks to reduce load when connecting. * Update log messages to be verbose instead of debug * Reviews * whoops * Explain a bit more how whitelist checking works * Apply CE's review * Append Membership to Blacklist and Whitelist conditions * Fix review comments * Uncapitalize playerConnectionWhitelist, add to ignored client prototypes * Make note count field work * Fix cvar for thingy --------- Co-authored-by: Pieter-Jan Briers <[email protected]> * Automatic changelog update * Automatic changelog update * bagel update (space-wizards#31535) * Station AI (space-wizards#30944) * Station AI overlay * implement * Bunch of ports * Fix a heap of bugs and basic scouting * helldivers * Shuffle interactions a bit * navmap stuff * Revert "navmap stuff" This reverts commit d1f89dd. * AI wires implemented * Fix examines * Optimise the overlay significantly * Back to old static * BUI radial working * lots of work * Saving work * thanks fork * alright * pc * AI upload console * AI upload * stuff * Fix copy-paste shitcode * AI actions * navmap work * Fixes * first impressions * a * reh * Revert "navmap work" This reverts commit 6f63fea. * OD * radar * weh * Fix examines * scoop mine eyes * fixes * reh * Optimise * Final round of optimisations * Fixes * fixes * Bagel station ai (space-wizards#31537) * real * AI * proto fix * Fix PostMapInit tests not considering job containerspawns (space-wizards#31538) * Fix PostMapInit tests nto considering job containerspawns * fix * AI whitelist fix (space-wizards#31542) * cog update (space-wizards#31540) updooted cog * AI radio fix (space-wizards#31547) Love to see it * Update AI holo sprite to camera (space-wizards#31558) Update AI camera to 13 default Holo was a placeholder. This is better in the interim. * Add AI warp points (space-wizards#31559) * Automatic changelog update * Fix AI being ejectable (space-wizards#31561) * Automatic changelog update * Fix whitelist (space-wizards#31563) * Automatic changelog update * bagel update (space-wizards#31562) * bagel update * ore processor cargo * Add some more stuff to AI whitelist (space-wizards#31564) * Add some more stuff to AI whitelist * by the nine * Automatic changelog update * Meta - Med disposals and chem room extra pipe fix (space-wizards#31467) Delete extra pipe & fix disposals junction * bagel hotfix (space-wizards#31566) bagel update * update AI job icon to 8x8 (space-wizards#31565) icon and meta.json * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * Automatic changelog update * fix spelling error silicon jobs (space-wizards#31581) Update department.ftl * Automatic changelog update * Fix defibs draining battery when turned off (space-wizards#31593) * Marathon - Names a singular camera (space-wizards#31590) Fixes unnamed camera * Automatic changelog update * Reach - Scientist added to map's prototype (space-wizards#31567) Added scientist to map prototype * Change my copyright (space-wizards#31599) * Remove random cyrillic letters (space-wizards#31600) * escape pod tiny fan (space-wizards#31601) * escape pod tiny fan * oop * Fix nuke disk erroneously being marked 'left behind' (space-wizards#31602) Fix erroneous 'disk left behind' objective * Automatic changelog update * bagel update (space-wizards#31603) * bagel update * light switch to make audience area darker in theatre * Add rings (Salvage loot real)! (space-wizards#31372) * First commit * I'm silly * Another fix * How could I forget the descriptions! * Forgot * Made textures alligned properly * Removed the stuff! * Opps * Typo fixes * Automatic changelog update * fix12312314234235 --------- Co-authored-by: PJBot <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Emisse <[email protected]> Co-authored-by: Spessmann <[email protected]> Co-authored-by: Winkarst <[email protected]> Co-authored-by: Mervill <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: IProduceWidgets <[email protected]> Co-authored-by: Simon <[email protected]> Co-authored-by: JustCone <[email protected]> Co-authored-by: lunarcomets <[email protected]> Co-authored-by: lzk <[email protected]> Co-authored-by: themias <[email protected]> Co-authored-by: beck-thompson <[email protected]>

@deltanedas

* Air alarms check sensors upon power returning * Update Credits (space-wizards#31409) Co-authored-by: PJBot <[email protected]> * Replace obsolete code in GasPortableSystem (space-wizards#31407) * Change `Resave` Permission Requirement to Host (space-wizards#31397) ChangePermissionFlagToHost * Automatic changelog update * Remove client state from server AirAlarmComponent (space-wizards#31236) * Remove client state from server AirAlarmComponent Send information for all connected devices, not just the ones for the current tab, as attempting to limit this breaks multiple users viewing the same UI. Fixes space-wizards#12842 * Send device data as a list, rather than a dictionary --------- Co-authored-by: Eoin Mcloughlin <[email protected]> * Fix ChemVend jugs again (space-wizards#31398) This re-introduces the dummy entity naming code, originally introduced in space-wizards#29178 and randomly removed by space-wizards#30064 with no technical justification given. Fixes space-wizards#31373 * Automatic changelog update * Fix dungeon spawn + ftl overlap (space-wizards#31413) * Fix dungeon spawn + ftl overlap * Better fixes * Automatic changelog update * Fix firelockedge rotation (space-wizards#31371) save * Automatic changelog update * Update Oasis (space-wizards#31415) * Cameras and junk * I forgot to clear my multitool * Automatic changelog update * marathon update (space-wizards#31421) * Give sec cadets jackboots instead of combat boots (space-wizards#31419) give cadets jackboots * Automatic changelog update * meta update (space-wizards#31423) * Adds the Head of Greytide stamp (space-wizards#30189) suggested changes from discord discussion, sprite change, add to refactored loot table * Automatic changelog update * Verb tweaks (space-wizards#31309) * Verb tweaks Remove the LOS check because this is already done above in CanExamine. * Fix outlines * import * Add ContainerComp (space-wizards#31311) Applies EntProtoId changes upon insertion / removal from container. Can also be useful for borgs / mechs / vehicles in future but atm I just used it for AI. * Blueprints (space-wizards#31138) * Blueprints * Update tables_loot.yml * doink * mark as required * Automatic changelog update * decouple ItemToggle from PowerCellDraw (space-wizards#31392) * remove ItemToggle from PowerCellDraw query * add EntityQuery for resolves, make them all optional * move integration to ToggleCellDraw * add ToggleCellDraw to almost every PowerCellDraw prototype *

*

* let it disable on mapinit * set update time on mapinit, make borg power logic consistent now *

--------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Automatic changelog update * Power stuff (space-wizards#31314) * Power stuff - Add shared IsPowered - Add shared ResolveApc - Move PowerChangedEvent to shared for now - Add SlimPoweredLight that actually functions how you'd expect a PoweredLight to function it id didn't have a bunch of bloat on it. * big update * boing * ItemToggle + slots stuff (space-wizards#31312) * ItemToggle + slots stuff - Add component for itemslot locks to match LockComponent (surprised this didn't exist). - Add thing for pointlight to match itemtoggle. In future should be used for PDAs and stuff but need to fix some other stuff first. * Also this * grill * Run actions on press (space-wizards#31191) I know UI generallys want to do stuff on key-up not key-down. With that being said the delay on release for these is noticeable. e.g. ActivateInWorld / UseInHand / any in-world interactions are on-press. This is especially noticeable if you have the same event on action + verb. * Automatic changelog update * Action stuff (space-wizards#31305) * Action stuff - Cleanup some event stuff - Avoid dirtying entity unnecessarily - Add ActionGrant as an easy way to apply / remove actions via compregistry. * Fix merge * Update submodule to 231.0.0 (space-wizards#31430) * Weather fix (space-wizards#30857) * weather fix * localize errors * ContainerComp fix (space-wizards#31434) Forgot to push these ones on the branch. * togglelight updates (space-wizards#31435) Missed in the green checkmark sea * Increase (SUPER)PACMAN ramp rate/tolerance (space-wizards#31403) All PACMANs used to use the same ramping parameters, this meant a SUPERPACMAN (50 kW) took literally a 100 seconds to get up to its full output level. Ouch. PACMAN has been raised to 5000 W/s with 1500 W tolerance, SUPERPACMAN to 7500 W/s with 2500 W tolerance * Automatic changelog update * Make space scanning T1 technology (space-wizards#31321) make space scanning and mass scanner t1 tech * Automatic changelog update * Add a bool to disable buckling on InteractHand (space-wizards#30001) * Automatic changelog update * fix(FieldGenerators): Don't show nonsense popup (space-wizards#30469) * . * bagel update (space-wizards#31440) * bagel update * fixgridatmos * qm office * sci cam fix * jesus christ so many routers * remove invalids * Fix-Resprite emote icons (space-wizards#31447) * Fix-Resprite emote icons * change scream * Moff cooking. Part one. (space-wizards#30668) * yml part * guidebook * commit * some fixes * a little * change * Automatic changelog update * Cog update (space-wizards#31458) made disposals less bad * Add BUI ctor tests (space-wizards#31463) 5 lines of eaten iocmanager.injectdependencies led to this. * Predict EmitSoundOnUIOpen (space-wizards#31464) * Predict EmitSoundOnUIOpen BUI prediction led to this moment. * unforky * Bots now make sound when they speak (space-wizards#31471) fixes 31454 * Automatic changelog update * Change the science radio channel color (space-wizards#31319) * Change the science radio channel color * This one looks better * Automatic changelog update * Move OnGhostAttempt to GhostSystem (space-wizards#31445) * Move OnGhostAttempt to GhostSystem * Remove unused dependencies and sort them * Fix energy sword visuals (space-wizards#31478) * Automatic changelog update * Replace obsolete code in shuttle systems. (space-wizards#31408) * Format DockingSystem.Shuttle * arrivals system * docking system * shuttle console system * emergency shuttle system * shuttle system * thruster system * Fix compile error --------- Co-authored-by: Pieter-Jan Briers <[email protected]> * Replaces small fans on most shuttles with directional fans. (space-wizards#31495) * Automatic changelog update * Replace obsolete functions in NPC systems (space-wizards#31448) * Make guidebook remember where you left off (space-wizards#31375) * Guidebook tracks last read entry * Persistent guidebook fixes * Persistent guidebook requested changes * Update Content.Client/UserInterface/Systems/Guidebook/GuidebookUIController.cs --------- Co-authored-by: Pieter-Jan Briers <[email protected]> * Automatic changelog update * Remove double-iteration from the mime wall code (space-wizards#31420) * Remove double-iteration from the mime wall code * Update * Update * fix method OnEntityEnter in DamageContactsSystem (space-wizards#31494) fix Co-authored-by: Dimastra <[email protected]> * Automatic changelog update * Make Gas Miners indestructable, anchorable, and pullable. (space-wizards#31370) * Make miner indestructable, and pullable. * Miners can't be unanchored. Only anchored. --------- Co-authored-by: JIPDawg <[email protected]> * Automatic changelog update * bagel update (space-wizards#31502) * Minor fixes to character profile editor save/reset buttons (space-wizards#31505) Merge SetDirty() with preview reload People were forgetting to SetDirty() when changing a property; move SetDirty() into preview reloading, since if the preview is being reloaded, some property has definitely changed anyway. Co-authored-by: Eoin Mcloughlin <[email protected]> * Centcom & FTLDestination cleanup (space-wizards#30226) * centcomm name and ftlcomp * networking microopstimization * go sleep. * map names and arrivals * Fix swapped around Safety Moth poster graphics (space-wizards#31507) * Automatic changelog update * Mark explosives as a contraband (space-wizards#31508) * Automatic changelog update * Mark the syndicate raid helmet as a Syndicate contraband (space-wizards#31512) * Automatic changelog update * Add title to multitool door-access-configuration window (space-wizards#31504) Fixes space-wizards#29923. Co-authored-by: Eoin Mcloughlin <[email protected]> * Restrict the explorer gas mask to cargo (space-wizards#31514) * Automatic changelog update * Fix stray pixel in officer beersky barsign (space-wizards#31517) * Scale text in admin player overlay (space-wizards#31503) * Scale text in admin player overlay Fixes space-wizards#30040 * Feedback from PR - get UI scale through root window --------- Co-authored-by: Eoin Mcloughlin <[email protected]> * New Health Analyzer UI (space-wizards#30834) * WIP: first prototype * Change text slightly * Allow names to wrap * Add label for the scan mode * Remove ugly text * Readd bleeding message * Update code * Allow for the Health Analyzer UI to grow vertically * Automatic changelog update * Disable Arrivals message for Cryosleep (space-wizards#30888) * Disable arrivals message for cryosleep late arrivals * Provide silent to PlayerSpawnCompleteEvent * Fix typo * Move message to event and into arrivals system * Automatic changelog update * Remove glibc from devshell (space-wizards#28842) * Automated whitelists (space-wizards#23985) * Beginnings of making the breadmemes jobs easier * stuff * stuff pt. 2 * Stuff pt.3 * Stuff I forgot last time * Basic whitelist Only people that are added to the whitelist with the addwhitelist command will be able to join. I call this the "legacy" whitelist * Remove always deny condition in favor of just breaking if playtime check fails * Change default whitelist Default whitelist is now the "legacy" whitelist. * localization * Admin check * minor spelling change * Fix build * Whitelist message * Fix vars not being datafield and spelling mistakes * Minor spelling mistake * Change config for salamander * Reviews and stuff * Add summaries * Fix whitelists * Forgot to add a datafield * Fixing stuff I guess * Reuse admin remarks to reduce load when connecting. * Update log messages to be verbose instead of debug * Reviews * whoops * Explain a bit more how whitelist checking works * Apply CE's review * Append Membership to Blacklist and Whitelist conditions * Fix review comments * Uncapitalize playerConnectionWhitelist, add to ignored client prototypes * Make note count field work * Fix cvar for thingy --------- Co-authored-by: Pieter-Jan Briers <[email protected]> * Make nukie plushie a non-contraband item (space-wizards#31516) Make nukie plushies a non-contraband item * Automatic changelog update * fix uncapitalized "S" in Salvage Specialist (space-wizards#31529) "Salvage specialist" to "Salvage Specialist"; all is right with the world * Make AKMS security restricted (space-wizards#31519) * Automatic changelog update * bagel update (space-wizards#31535) * Update submodule to 231.1.0 (space-wizards#31536) * Station AI (space-wizards#30944) * Station AI overlay * implement * Bunch of ports * Fix a heap of bugs and basic scouting * helldivers * Shuffle interactions a bit * navmap stuff * Revert "navmap stuff" This reverts commit d1f89dd. * AI wires implemented * Fix examines * Optimise the overlay significantly * Back to old static * BUI radial working * lots of work * Saving work * thanks fork * alright * pc * AI upload console * AI upload * stuff * Fix copy-paste shitcode * AI actions * navmap work * Fixes * first impressions * a * reh * Revert "navmap work" This reverts commit 6f63fea. # Conflicts: # Content.Client/Silicons/StationAi/StationAiOverlay.cs * OD * radar * weh * Fix examines * scoop mine eyes * fixes * reh * Optimise * Final round of optimisations * Fixes * fixes * Bagel station ai (space-wizards#31537) * real * AI * proto fix * Fix PostMapInit tests not considering job containerspawns (space-wizards#31538) * Fix PostMapInit tests nto considering job containerspawns * fix * AI whitelist fix (space-wizards#31542) * cog update (space-wizards#31540) updooted cog * AI radio fix (space-wizards#31547) Love to see it * Storage BUI bandaid (space-wizards#31506) grug storageuicontroller * Fix puddle context menu (space-wizards#31555) * Update AI holo sprite to camera (space-wizards#31558) Update AI camera to 13 default Holo was a placeholder. This is better in the interim. * Add AI warp points (space-wizards#31559) * Automatic changelog update * Fix AI being ejectable (space-wizards#31561) * Automatic changelog update * Fix whitelist (space-wizards#31563) * Automatic changelog update * bagel update (space-wizards#31562) * bagel update * ore processor cargo * Add some more stuff to AI whitelist (space-wizards#31564) * Add some more stuff to AI whitelist * by the nine * Automatic changelog update * Meta - Med disposals and chem room extra pipe fix (space-wizards#31467) Delete extra pipe & fix disposals junction * bagel hotfix (space-wizards#31566) bagel update * update AI job icon to 8x8 (space-wizards#31565) icon and meta.json * Automatic changelog update * Update ClothingSpeedModifierSystem.cs (space-wizards#29994) * TryGetContainerContainer * Math * Changed AddMarkup to AddMarkupOrThrow * Better math * engine version * engine version * Add black suspenders (space-wizards#29055) * Black suspenders * fix * fix linter * Automatic changelog update * recolor riot helmet (space-wizards#31530) * recolor riot helmet resolves space-wizards#31256 match riot helmet to default security helmet * further color tweaks for consistency; update meta.json Tweaked equipped sprites to more closely match the security helmet. * Automatic changelog update * added wide-spectrum anomaly locator to anomaly cyborg module (space-wizards#31427) added wide-spectrum anomaly locator to anomaly borg module * Automatic changelog update * Add Robust.Xaml.csproj to the solution (space-wizards#31573) * add construction for carp statue (space-wizards#31261) * separate eyes and teeth * make it buildable and make fixture less abusable * norot --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Automatic changelog update * fix spelling error silicon jobs (space-wizards#31581) Update department.ftl * Fixes shuttles not being able to FTL onto/near station (space-wizards#31569) fixes FTL * Automatic changelog update * Fix defibs draining battery when turned off (space-wizards#31593) * Bagel - LV cable wasn't connected (space-wizards#31591) fixes a missing wire * Marathon - Names a singular camera (space-wizards#31590) Fixes unnamed camera * Automatic changelog update * Reach - Scientist added to map's prototype (space-wizards#31567) Added scientist to map prototype * Change my copyright (space-wizards#31599) * Remove random cyrillic letters (space-wizards#31600) * escape pod tiny fan (space-wizards#31601) * escape pod tiny fan * oop * Fix nuke disk erroneously being marked 'left behind' (space-wizards#31602) Fix erroneous 'disk left behind' objective * Automatic changelog update * bagel update (space-wizards#31603) * bagel update * light switch to make audience area darker in theatre * Add rings (Salvage loot real)! (space-wizards#31372) * First commit * I'm silly * Another fix * How could I forget the descriptions! * Forgot * Made textures alligned properly * Removed the stuff! * Opps * Typo fixes * Automatic changelog update * bagel update (space-wizards#31605) * Sec Webbing Icon Resprite and Rename (space-wizards#29599) * Sec Webbing Icon Resprite and Rename * Renamed To Security Carrier * Cherry (space-wizards#28962) * Add files via upload * Update produce.yml * Update produce.yml * Update seeds.yml * Update flavor-profiles.ftl * Update flavors.yml * Update meal_recipes.yml * Update food_produce.yml * Update meta.json * Update seeds.yml * Update botany.yml * Delete Resources/Textures/Objects/Specific/Hydroponics/cherry.rsi/meta.json * Create meta.json * Delete Resources/Textures/Objects/Specific/Hydroponics/cherry.rsi/meta.json * Create meta.json * Update produce.yml * Update produce.yml * Update produce.yml * Update food_produce.yml * Update food_produce.yml * Update produce.yml * Apply suggestions from code review Co-authored-by: Tayrtahn <[email protected]> * Update seeds.yml * Update juice.yml * Update juice.ftl * Update seeds.ftl * Update seeds.yml * Update cargo_botany.yml * Update cargo_botany.yml * Update cargo_botany.yml * Update cargo_vending.yml * Update cargo_vending.yml * Update seeds.yml * Update seeds.yml * Update meta.json * Update produce.yml * Cherry Tree * Alphabetical order * Update food_produce.yml * Update food-sequence.ftl * Update food-sequence.ftl * Update produce.yml * Update produce.yml * Update food-sequence.ftl --------- Co-authored-by: Tayrtahn <[email protected]> * Automatic changelog update * Add Command Glasses (space-wizards#30447) * Initial commit * Removed wanted and mindshield status display * Updated glasses visuals & contraband status * Added Command Hud * Changed name to administration glasses/hud * Automatic changelog update * Added plastitanium walls and windows (space-wizards#31178) * added plastitanium walls and windows * Changed crack sprite on diagonal window from square to diagonal * Automatic changelog update * Make railings render over tables (space-wizards#31589) Make rails render over tables * Automatic changelog update * Update submodule to 232.0.0 (space-wizards#31616) * Automatic changelog update * Fixup playerspawn stuff (space-wizards#31546) * Fixup playerspawn stuff - Also removed arrivals forcing, this should just turn containerspawnpoint off. * fix this one * test fix * really fix * strange pill tweaks (space-wizards#30524) * fix randomfill logic * Revert "fix randomfill logic" This reverts commit 7cd73c0. * change strange pill weights * proposed balance changes * Automatic changelog update * Fix openable visuals (space-wizards#31484) First commit * reduce lathe recipe copy pasta (space-wizards#31515) * add inheritance to lathe recipes and make result an override * add GetResult method to lathe system * make other parts of the code use GetResult * clean up the stock parts yml * remove unused apu boards from dynamic recipes * make inverse dictionary public so test doesnt have to copy paste * revert result override stuff --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * cog update (space-wizards#31631) * cog update * woopsie, fixed that * fix cherries * fix cherries 2 electric boogaloo * fix maps --------- Co-authored-by: osjarw <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: PJBot <[email protected]> Co-authored-by: Mervill <[email protected]> Co-authored-by: PursuitInAshes <[email protected]> Co-authored-by: eoineoineoin <[email protected]> Co-authored-by: Eoin Mcloughlin <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: themias <[email protected]> Co-authored-by: IProduceWidgets <[email protected]> Co-authored-by: Emisse <[email protected]> Co-authored-by: PopGamer46 <[email protected]> Co-authored-by: ArtisticRoomba <[email protected]> Co-authored-by: Nemanja <[email protected]> Co-authored-by: deltanedas <[email protected]> Co-authored-by: Ed <[email protected]> Co-authored-by: Alzore <[email protected]> Co-authored-by: ShadowCommander <[email protected]> Co-authored-by: Brandon Hu <[email protected]> Co-authored-by: lzk <[email protected]> Co-authored-by: Spessmann <[email protected]> Co-authored-by: Moomoobeef <[email protected]> Co-authored-by: Winkarst <[email protected]> Co-authored-by: slarticodefast <[email protected]> Co-authored-by: QueerNB <[email protected]> Co-authored-by: 12rabbits <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: Dimastra <[email protected]> Co-authored-by: Dimastra <[email protected]> Co-authored-by: JIPDawg <[email protected]> Co-authored-by: JIPDawg <[email protected]> Co-authored-by: Saphire Lattice <[email protected]> Co-authored-by: Thomas <[email protected]> Co-authored-by: stellar-novas <[email protected]> Co-authored-by: Simon <[email protected]> Co-authored-by: saintmuntzer <[email protected]> Co-authored-by: JustCone <[email protected]> Co-authored-by: lunarcomets <[email protected]> Co-authored-by: Errant <[email protected]> Co-authored-by: coolboy911 <[email protected]> Co-authored-by: beck-thompson <[email protected]> Co-authored-by: DieselMohawk <[email protected]> Co-authored-by: RumiTiger <[email protected]> Co-authored-by: Tayrtahn <[email protected]> Co-authored-by: SlamBamActionman <[email protected]> Co-authored-by: Unisol <[email protected]> Co-authored-by: Partmedia <[email protected]> Co-authored-by: MisterMecky <[email protected]>

@deltanedas

* Air alarms check sensors upon power returning * Update Credits (space-wizards#31409) Co-authored-by: PJBot <[email protected]> * Replace obsolete code in GasPortableSystem (space-wizards#31407) * Change `Resave` Permission Requirement to Host (space-wizards#31397) ChangePermissionFlagToHost * Automatic changelog update * Remove client state from server AirAlarmComponent (space-wizards#31236) * Remove client state from server AirAlarmComponent Send information for all connected devices, not just the ones for the current tab, as attempting to limit this breaks multiple users viewing the same UI. Fixes space-wizards#12842 * Send device data as a list, rather than a dictionary --------- Co-authored-by: Eoin Mcloughlin <[email protected]> * Fix ChemVend jugs again (space-wizards#31398) This re-introduces the dummy entity naming code, originally introduced in space-wizards#29178 and randomly removed by space-wizards#30064 with no technical justification given. Fixes space-wizards#31373 * Automatic changelog update * Fix dungeon spawn + ftl overlap (space-wizards#31413) * Fix dungeon spawn + ftl overlap * Better fixes * Automatic changelog update * Fix firelockedge rotation (space-wizards#31371) save * Automatic changelog update * Update Oasis (space-wizards#31415) * Cameras and junk * I forgot to clear my multitool * Automatic changelog update * marathon update (space-wizards#31421) * Give sec cadets jackboots instead of combat boots (space-wizards#31419) give cadets jackboots * Automatic changelog update * meta update (space-wizards#31423) * Adds the Head of Greytide stamp (space-wizards#30189) suggested changes from discord discussion, sprite change, add to refactored loot table * Automatic changelog update * Verb tweaks (space-wizards#31309) * Verb tweaks Remove the LOS check because this is already done above in CanExamine. * Fix outlines * import * Add ContainerComp (space-wizards#31311) Applies EntProtoId changes upon insertion / removal from container. Can also be useful for borgs / mechs / vehicles in future but atm I just used it for AI. * Blueprints (space-wizards#31138) * Blueprints * Update tables_loot.yml * doink * mark as required * Automatic changelog update * decouple ItemToggle from PowerCellDraw (space-wizards#31392) * remove ItemToggle from PowerCellDraw query * add EntityQuery for resolves, make them all optional * move integration to ToggleCellDraw * add ToggleCellDraw to almost every PowerCellDraw prototype *

*

* let it disable on mapinit * set update time on mapinit, make borg power logic consistent now *

--------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Automatic changelog update * Power stuff (space-wizards#31314) * Power stuff - Add shared IsPowered - Add shared ResolveApc - Move PowerChangedEvent to shared for now - Add SlimPoweredLight that actually functions how you'd expect a PoweredLight to function it id didn't have a bunch of bloat on it. * big update * boing * ItemToggle + slots stuff (space-wizards#31312) * ItemToggle + slots stuff - Add component for itemslot locks to match LockComponent (surprised this didn't exist). - Add thing for pointlight to match itemtoggle. In future should be used for PDAs and stuff but need to fix some other stuff first. * Also this * grill * Run actions on press (space-wizards#31191) I know UI generallys want to do stuff on key-up not key-down. With that being said the delay on release for these is noticeable. e.g. ActivateInWorld / UseInHand / any in-world interactions are on-press. This is especially noticeable if you have the same event on action + verb. * Automatic changelog update * Action stuff (space-wizards#31305) * Action stuff - Cleanup some event stuff - Avoid dirtying entity unnecessarily - Add ActionGrant as an easy way to apply / remove actions via compregistry. * Fix merge * Update submodule to 231.0.0 (space-wizards#31430) * Weather fix (space-wizards#30857) * weather fix * localize errors * ContainerComp fix (space-wizards#31434) Forgot to push these ones on the branch. * togglelight updates (space-wizards#31435) Missed in the green checkmark sea * Increase (SUPER)PACMAN ramp rate/tolerance (space-wizards#31403) All PACMANs used to use the same ramping parameters, this meant a SUPERPACMAN (50 kW) took literally a 100 seconds to get up to its full output level. Ouch. PACMAN has been raised to 5000 W/s with 1500 W tolerance, SUPERPACMAN to 7500 W/s with 2500 W tolerance * Automatic changelog update * Make space scanning T1 technology (space-wizards#31321) make space scanning and mass scanner t1 tech * Automatic changelog update * Add a bool to disable buckling on InteractHand (space-wizards#30001) * Automatic changelog update * fix(FieldGenerators): Don't show nonsense popup (space-wizards#30469) * . * bagel update (space-wizards#31440) * bagel update * fixgridatmos * qm office * sci cam fix * jesus christ so many routers * remove invalids * Fix-Resprite emote icons (space-wizards#31447) * Fix-Resprite emote icons * change scream * Moff cooking. Part one. (space-wizards#30668) * yml part * guidebook * commit * some fixes * a little * change * Automatic changelog update * Cog update (space-wizards#31458) made disposals less bad * Add BUI ctor tests (space-wizards#31463) 5 lines of eaten iocmanager.injectdependencies led to this. * Predict EmitSoundOnUIOpen (space-wizards#31464) * Predict EmitSoundOnUIOpen BUI prediction led to this moment. * unforky * Bots now make sound when they speak (space-wizards#31471) fixes 31454 * Automatic changelog update * Change the science radio channel color (space-wizards#31319) * Change the science radio channel color * This one looks better * Automatic changelog update * Move OnGhostAttempt to GhostSystem (space-wizards#31445) * Move OnGhostAttempt to GhostSystem * Remove unused dependencies and sort them * Fix energy sword visuals (space-wizards#31478) * Automatic changelog update * Replace obsolete code in shuttle systems. (space-wizards#31408) * Format DockingSystem.Shuttle * arrivals system * docking system * shuttle console system * emergency shuttle system * shuttle system * thruster system * Fix compile error --------- Co-authored-by: Pieter-Jan Briers <[email protected]> * Replaces small fans on most shuttles with directional fans. (space-wizards#31495) * Automatic changelog update * Replace obsolete functions in NPC systems (space-wizards#31448) * Make guidebook remember where you left off (space-wizards#31375) * Guidebook tracks last read entry * Persistent guidebook fixes * Persistent guidebook requested changes * Update Content.Client/UserInterface/Systems/Guidebook/GuidebookUIController.cs --------- Co-authored-by: Pieter-Jan Briers <[email protected]> * Automatic changelog update * Remove double-iteration from the mime wall code (space-wizards#31420) * Remove double-iteration from the mime wall code * Update * Update * fix method OnEntityEnter in DamageContactsSystem (space-wizards#31494) fix Co-authored-by: Dimastra <[email protected]> * Automatic changelog update * Make Gas Miners indestructable, anchorable, and pullable. (space-wizards#31370) * Make miner indestructable, and pullable. * Miners can't be unanchored. Only anchored. --------- Co-authored-by: JIPDawg <[email protected]> * Automatic changelog update * bagel update (space-wizards#31502) * Minor fixes to character profile editor save/reset buttons (space-wizards#31505) Merge SetDirty() with preview reload People were forgetting to SetDirty() when changing a property; move SetDirty() into preview reloading, since if the preview is being reloaded, some property has definitely changed anyway. Co-authored-by: Eoin Mcloughlin <[email protected]> * Centcom & FTLDestination cleanup (space-wizards#30226) * centcomm name and ftlcomp * networking microopstimization * go sleep. * map names and arrivals * Fix swapped around Safety Moth poster graphics (space-wizards#31507) * Automatic changelog update * Mark explosives as a contraband (space-wizards#31508) * Automatic changelog update * Mark the syndicate raid helmet as a Syndicate contraband (space-wizards#31512) * Automatic changelog update * Add title to multitool door-access-configuration window (space-wizards#31504) Fixes space-wizards#29923. Co-authored-by: Eoin Mcloughlin <[email protected]> * Restrict the explorer gas mask to cargo (space-wizards#31514) * Automatic changelog update * Fix stray pixel in officer beersky barsign (space-wizards#31517) * Scale text in admin player overlay (space-wizards#31503) * Scale text in admin player overlay Fixes space-wizards#30040 * Feedback from PR - get UI scale through root window --------- Co-authored-by: Eoin Mcloughlin <[email protected]> * New Health Analyzer UI (space-wizards#30834) * WIP: first prototype * Change text slightly * Allow names to wrap * Add label for the scan mode * Remove ugly text * Readd bleeding message * Update code * Allow for the Health Analyzer UI to grow vertically * Automatic changelog update * Disable Arrivals message for Cryosleep (space-wizards#30888) * Disable arrivals message for cryosleep late arrivals * Provide silent to PlayerSpawnCompleteEvent * Fix typo * Move message to event and into arrivals system * Automatic changelog update * Remove glibc from devshell (space-wizards#28842) * Automated whitelists (space-wizards#23985) * Beginnings of making the breadmemes jobs easier * stuff * stuff pt. 2 * Stuff pt.3 * Stuff I forgot last time * Basic whitelist Only people that are added to the whitelist with the addwhitelist command will be able to join. I call this the "legacy" whitelist * Remove always deny condition in favor of just breaking if playtime check fails * Change default whitelist Default whitelist is now the "legacy" whitelist. * localization * Admin check * minor spelling change * Fix build * Whitelist message * Fix vars not being datafield and spelling mistakes * Minor spelling mistake * Change config for salamander * Reviews and stuff * Add summaries * Fix whitelists * Forgot to add a datafield * Fixing stuff I guess * Reuse admin remarks to reduce load when connecting. * Update log messages to be verbose instead of debug * Reviews * whoops * Explain a bit more how whitelist checking works * Apply CE's review * Append Membership to Blacklist and Whitelist conditions * Fix review comments * Uncapitalize playerConnectionWhitelist, add to ignored client prototypes * Make note count field work * Fix cvar for thingy --------- Co-authored-by: Pieter-Jan Briers <[email protected]> * Make nukie plushie a non-contraband item (space-wizards#31516) Make nukie plushies a non-contraband item * Automatic changelog update * fix uncapitalized "S" in Salvage Specialist (space-wizards#31529) "Salvage specialist" to "Salvage Specialist"; all is right with the world * Make AKMS security restricted (space-wizards#31519) * Automatic changelog update * bagel update (space-wizards#31535) * Update submodule to 231.1.0 (space-wizards#31536) * Station AI (space-wizards#30944) * Station AI overlay * implement * Bunch of ports * Fix a heap of bugs and basic scouting * helldivers * Shuffle interactions a bit * navmap stuff * Revert "navmap stuff" This reverts commit d1f89dd. * AI wires implemented * Fix examines * Optimise the overlay significantly * Back to old static * BUI radial working * lots of work * Saving work * thanks fork * alright * pc * AI upload console * AI upload * stuff * Fix copy-paste shitcode * AI actions * navmap work * Fixes * first impressions * a * reh * Revert "navmap work" This reverts commit 6f63fea. # Conflicts: # Content.Client/Silicons/StationAi/StationAiOverlay.cs * OD * radar * weh * Fix examines * scoop mine eyes * fixes * reh * Optimise * Final round of optimisations * Fixes * fixes * Bagel station ai (space-wizards#31537) * real * AI * proto fix * Fix PostMapInit tests not considering job containerspawns (space-wizards#31538) * Fix PostMapInit tests nto considering job containerspawns * fix * AI whitelist fix (space-wizards#31542) * cog update (space-wizards#31540) updooted cog * AI radio fix (space-wizards#31547) Love to see it * Storage BUI bandaid (space-wizards#31506) grug storageuicontroller * Fix puddle context menu (space-wizards#31555) * Update AI holo sprite to camera (space-wizards#31558) Update AI camera to 13 default Holo was a placeholder. This is better in the interim. * Add AI warp points (space-wizards#31559) * Automatic changelog update * Fix AI being ejectable (space-wizards#31561) * Automatic changelog update * Fix whitelist (space-wizards#31563) * Automatic changelog update * bagel update (space-wizards#31562) * bagel update * ore processor cargo * Add some more stuff to AI whitelist (space-wizards#31564) * Add some more stuff to AI whitelist * by the nine * Automatic changelog update * Meta - Med disposals and chem room extra pipe fix (space-wizards#31467) Delete extra pipe & fix disposals junction * bagel hotfix (space-wizards#31566) bagel update * update AI job icon to 8x8 (space-wizards#31565) icon and meta.json * Automatic changelog update * Update ClothingSpeedModifierSystem.cs (space-wizards#29994) * TryGetContainerContainer * Math * Changed AddMarkup to AddMarkupOrThrow * Better math * engine version * engine version * Add black suspenders (space-wizards#29055) * Black suspenders * fix * fix linter * Automatic changelog update * recolor riot helmet (space-wizards#31530) * recolor riot helmet resolves space-wizards#31256 match riot helmet to default security helmet * further color tweaks for consistency; update meta.json Tweaked equipped sprites to more closely match the security helmet. * Automatic changelog update * added wide-spectrum anomaly locator to anomaly cyborg module (space-wizards#31427) added wide-spectrum anomaly locator to anomaly borg module * Automatic changelog update * Add Robust.Xaml.csproj to the solution (space-wizards#31573) * add construction for carp statue (space-wizards#31261) * separate eyes and teeth * make it buildable and make fixture less abusable * norot --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Automatic changelog update * fix spelling error silicon jobs (space-wizards#31581) Update department.ftl * Fixes shuttles not being able to FTL onto/near station (space-wizards#31569) fixes FTL * Automatic changelog update * Fix defibs draining battery when turned off (space-wizards#31593) * Bagel - LV cable wasn't connected (space-wizards#31591) fixes a missing wire * Marathon - Names a singular camera (space-wizards#31590) Fixes unnamed camera * Automatic changelog update * Reach - Scientist added to map's prototype (space-wizards#31567) Added scientist to map prototype * Change my copyright (space-wizards#31599) * Remove random cyrillic letters (space-wizards#31600) * escape pod tiny fan (space-wizards#31601) * escape pod tiny fan * oop * Fix nuke disk erroneously being marked 'left behind' (space-wizards#31602) Fix erroneous 'disk left behind' objective * Automatic changelog update * bagel update (space-wizards#31603) * bagel update * light switch to make audience area darker in theatre * Add rings (Salvage loot real)! (space-wizards#31372) * First commit * I'm silly * Another fix * How could I forget the descriptions! * Forgot * Made textures alligned properly * Removed the stuff! * Opps * Typo fixes * Automatic changelog update * bagel update (space-wizards#31605) * Sec Webbing Icon Resprite and Rename (space-wizards#29599) * Sec Webbing Icon Resprite and Rename * Renamed To Security Carrier * Cherry (space-wizards#28962) * Add files via upload * Update produce.yml * Update produce.yml * Update seeds.yml * Update flavor-profiles.ftl * Update flavors.yml * Update meal_recipes.yml * Update food_produce.yml * Update meta.json * Update seeds.yml * Update botany.yml * Delete Resources/Textures/Objects/Specific/Hydroponics/cherry.rsi/meta.json * Create meta.json * Delete Resources/Textures/Objects/Specific/Hydroponics/cherry.rsi/meta.json * Create meta.json * Update produce.yml * Update produce.yml * Update produce.yml * Update food_produce.yml * Update food_produce.yml * Update produce.yml * Apply suggestions from code review Co-authored-by: Tayrtahn <[email protected]> * Update seeds.yml * Update juice.yml * Update juice.ftl * Update seeds.ftl * Update seeds.yml * Update cargo_botany.yml * Update cargo_botany.yml * Update cargo_botany.yml * Update cargo_vending.yml * Update cargo_vending.yml * Update seeds.yml * Update seeds.yml * Update meta.json * Update produce.yml * Cherry Tree * Alphabetical order * Update food_produce.yml * Update food-sequence.ftl * Update food-sequence.ftl * Update produce.yml * Update produce.yml * Update food-sequence.ftl --------- Co-authored-by: Tayrtahn <[email protected]> * Automatic changelog update * Add Command Glasses (space-wizards#30447) * Initial commit * Removed wanted and mindshield status display * Updated glasses visuals & contraband status * Added Command Hud * Changed name to administration glasses/hud * Automatic changelog update * Added plastitanium walls and windows (space-wizards#31178) * added plastitanium walls and windows * Changed crack sprite on diagonal window from square to diagonal * Automatic changelog update * Make railings render over tables (space-wizards#31589) Make rails render over tables * Automatic changelog update * Update submodule to 232.0.0 (space-wizards#31616) * Automatic changelog update * Fixup playerspawn stuff (space-wizards#31546) * Fixup playerspawn stuff - Also removed arrivals forcing, this should just turn containerspawnpoint off. * fix this one * test fix * really fix * strange pill tweaks (space-wizards#30524) * fix randomfill logic * Revert "fix randomfill logic" This reverts commit 7cd73c0. * change strange pill weights * proposed balance changes * Automatic changelog update * Fix openable visuals (space-wizards#31484) First commit * reduce lathe recipe copy pasta (space-wizards#31515) * add inheritance to lathe recipes and make result an override * add GetResult method to lathe system * make other parts of the code use GetResult * clean up the stock parts yml * remove unused apu boards from dynamic recipes * make inverse dictionary public so test doesnt have to copy paste * revert result override stuff --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * cog update (space-wizards#31631) * cog update * woopsie, fixed that * Fix energy shield visuals (space-wizards#31619) fix energy shield visuals * Automatic changelog update * Added Armband Onto Back Sprite of Security Jumpsuit (space-wizards#31635) * Fixed Minor Mistake * Fixed the NEW sprite and added Jumpskirt Fix * Automatic changelog update * Add SpriteFadeComponent to potted plants (space-wizards#31628) * Automatic changelog update * Meteor rock debuff (space-wizards#31651) * Makes meteor swarms spawn meteorite walls with 1/10 health of an asteroid wall. * Changed MeteorRock prototype base - Rebased MeteorRock to AsteroidRock from Basewall - MeteorRock now only changes the Destructible damage value * Tried to fix comments * Automatic changelog update * Fix test threading (space-wizards#31669) * Fix revenant being blocked by walls (space-wizards#31670) fix revenant being blocked by walls * Automatic changelog update * Update submodule to 233.0.0 (space-wizards#31673) * Fix broken tests directly mutating entities from wrong thread. (space-wizards#31647) * Fix broken tests directly mutating entities from wrong thread. * fix build * gundam * stuff --------- Co-authored-by: metalgearsloth <[email protected]> * Fix AI singulo shenanigans (space-wizards#31556) * weh * Fix broken tests directly mutating entities from wrong thread. * fix build * gundam * weher * WHY --------- Co-authored-by: Pieter-Jan Briers <[email protected]> * Update submodule to 233.0.1 (space-wizards#31676) * Automatic changelog update * Fix suicide logs (space-wizards#31661) Make suicide logs include the username, as well as the character(where possible) * Automatic changelog update * More ItemTogglePointLight fixes (space-wizards#31655) more ItemTogglePointLight fixes * Automatic changelog update * Allow for respawn and erase verb to be used on offline players. Also minor rewrite on respawn command and new erase command (space-wizards#30433) * Localize respawn command, allow for it to use userids, and make it use [Dependency] attributes * Make respawn verb available for offline players * Make erase available for offline players A thousand admins rejoice * Reorder verbs in code * Add erase command * Fix localisation for erase command * Address reviews and add completion to respawn command * Complete reviews which I forgor * Automatic changelog update --------- Co-authored-by: osjarw <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: PJBot <[email protected]> Co-authored-by: Mervill <[email protected]> Co-authored-by: PursuitInAshes <[email protected]> Co-authored-by: eoineoineoin <[email protected]> Co-authored-by: Eoin Mcloughlin <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: themias <[email protected]> Co-authored-by: IProduceWidgets <[email protected]> Co-authored-by: Emisse <[email protected]> Co-authored-by: PopGamer46 <[email protected]> Co-authored-by: ArtisticRoomba <[email protected]> Co-authored-by: Nemanja <[email protected]> Co-authored-by: deltanedas <[email protected]> Co-authored-by: Ed <[email protected]> Co-authored-by: Alzore <[email protected]> Co-authored-by: ShadowCommander <[email protected]> Co-authored-by: Brandon Hu <[email protected]> Co-authored-by: lzk <[email protected]> Co-authored-by: Spessmann <[email protected]> Co-authored-by: Moomoobeef <[email protected]> Co-authored-by: Winkarst <[email protected]> Co-authored-by: slarticodefast <[email protected]> Co-authored-by: QueerNB <[email protected]> Co-authored-by: 12rabbits <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: Dimastra <[email protected]> Co-authored-by: Dimastra <[email protected]> Co-authored-by: JIPDawg <[email protected]> Co-authored-by: JIPDawg <[email protected]> Co-authored-by: Saphire Lattice <[email protected]> Co-authored-by: Thomas <[email protected]> Co-authored-by: stellar-novas <[email protected]> Co-authored-by: Simon <[email protected]> Co-authored-by: saintmuntzer <[email protected]> Co-authored-by: JustCone <[email protected]> Co-authored-by: lunarcomets <[email protected]> Co-authored-by: Errant <[email protected]> Co-authored-by: coolboy911 <[email protected]> Co-authored-by: beck-thompson <[email protected]> Co-authored-by: DieselMohawk <[email protected]> Co-authored-by: RumiTiger <[email protected]> Co-authored-by: Tayrtahn <[email protected]> Co-authored-by: SlamBamActionman <[email protected]> Co-authored-by: Unisol <[email protected]> Co-authored-by: Partmedia <[email protected]> Co-authored-by: MisterMecky <[email protected]> Co-authored-by: AutoOtter <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: nikthechampiongr <[email protected]>

Move OnGhostAttempt to GhostSystem

27c075d

Winkarst-cpu requested review from Jezithyr and EmoGarbage404 as code owners August 25, 2024 22:45

github-actions bot added the S: Needs Review Indicates an item that requires new reviews. label Aug 25, 2024

slarticodefast requested changes Aug 26, 2024

View reviewed changes

Content.Server/Bed/Cryostorage/CryostorageSystem.cs Outdated Show resolved Hide resolved

slarticodefast added the S: Awaiting Changes Indicates an item is awaiting changes. label Aug 26, 2024

Remove unused dependencies and sort them

4fbe6fc

Winkarst-cpu requested a review from slarticodefast August 26, 2024 11:03

github-actions bot removed the S: Awaiting Changes Indicates an item is awaiting changes. label Aug 26, 2024

slarticodefast approved these changes Aug 26, 2024

View reviewed changes

slarticodefast merged commit 2d85b4e into space-wizards:master Aug 26, 2024
12 checks passed

Winkarst-cpu deleted the onghostattempt-ghostsystem branch August 26, 2024 12:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move OnGhostAttempt to GhostSystem #31445

Move OnGhostAttempt to GhostSystem #31445

Winkarst-cpu commented Aug 25, 2024 •

edited

Loading

Plykiya commented Aug 25, 2024

slarticodefast left a comment

slarticodefast commented Aug 26, 2024

Move OnGhostAttempt to GhostSystem #31445

Move OnGhostAttempt to GhostSystem #31445

Conversation

Winkarst-cpu commented Aug 25, 2024 • edited Loading

About the PR

Why / Balance

Technical details

Media

Requirements

Breaking changes

Plykiya commented Aug 25, 2024

slarticodefast left a comment

Choose a reason for hiding this comment

slarticodefast commented Aug 26, 2024

Winkarst-cpu commented Aug 25, 2024 •

edited

Loading