-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix scram, revert #26429 #31482
base: master
Are you sure you want to change the base?
fix scram, revert #26429 #31482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i approve of this
This would be a much needed buff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the existing code to do what is preferred rather than leaving in poorly optimised code that teleports arbitrarily.
2e2f9d8
to
d425dfb
Compare
i believe i should mention this, but from testing, the tries20 method works 20 to 50 times faster than the one i am reverting |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…wizards#26429)" This reverts commit 2ffd616.
About the PR
fixes #31480
why is this a revert? i believe that #26429 is a de-optimisation, since i presume it would be faster to check the 20 or so tiles the tries20 picks rather than the 31k or so tiles in range; i think tries20 is actually the efficient implementation for this
however, it's possible i am wrong regarding the above, so correct me if i am; in that case, i will make a PR that removes the range sqrt, as opposed to a revert
however, another issue is that when i tested a fix involving simply removing the sqrt, it tended to very often teleport you into space
additionally, tries20 will naturally prioritise larger grids near itself and be less likely to teleport you into space if you're far into the station
Why / Balance
this is a fix - irrelevant
Technical details
makes scram use tries20 to find a valid tile
Media
tested, works, consistently gives luckier (minimal TP into walls or into space) teleports than before even with raised range
Requirements
Changelog
🆑