Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes snap pop explosions unable to throw away items #31617

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

PopGamer45
Copy link
Contributor

@PopGamer45 PopGamer45 commented Aug 29, 2024

About the PR

Resolves #31611. Snap pops were indirectly spilling/destroying beakers and such by throwing them away with the explosion which spilled them because beakers and similar get spilled when someone throws them. This pr resolves this by adding a canThrowItems variable to the ExplosiveComponent.

Why / Balance

Snap pops are supposed to be harmless and purely cosmetic, being able to spill/destroy piled up (which if i recall correctly medbay often has piled up jugs on a single table) beakers and such with them isnt very good.

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑 PopGamer46

  • tweak: Snap pops can no longer spill/destroy beakers, jugs and similar

@UbaserB UbaserB added the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Aug 31, 2024
@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 19, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snap pops should not spill jugs
2 participants