Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sprite layering upon buckling/unbuckling #31625

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

themias
Copy link
Contributor

@themias themias commented Aug 29, 2024

About the PR

Fixes #31583

Technical details

We already have logic for updating the draw depth of a character upon rotating in a chair. This adds that same logic when buckling into or out of a chair.

This way, unbuckling from a chair resets the draw depth, and buckling into a north-facing chair will lower the draw depth appropriately.

Media

chair-rotation-demo.mp4

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • fix: Fixed players sometimes rendering under tables

@Winkarst-cpu
Copy link
Contributor

With CL would be better.

@ps3moira
Copy link
Contributor

ps3moira commented Sep 1, 2024

Since we have mapping, isn't it possible to make mapping for chairs?

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 22, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

# Conflicts:
#	Content.Client/Buckle/BuckleSystem.cs
@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes you can go underneath tables
3 participants