Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crew Monitor filter #31659

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Crew Monitor filter #31659

merged 2 commits into from
Sep 19, 2024

Conversation

Errant-4
Copy link
Contributor

About the PR

The crew monitor now has a filter, that looks in both Name and Job

Why / Balance

QOL change, particularly for AI (once it's crew monitor gets fixed)

Media

crewmon.mp4

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑 Errant

  • add: Crew monitor list can now be filtered by name and job.

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design labels Aug 30, 2024
@ScarKy0
Copy link
Contributor

ScarKy0 commented Aug 30, 2024

Great change for both AI and generally, thank you

@Errant-4
Copy link
Contributor Author

Would it add much if the department headers for no-result departments were taken off?

@ScarKy0
Copy link
Contributor

ScarKy0 commented Aug 31, 2024

Would it add much if the department headers for no-result departments were taken off?

Not really, i think it can stay, can help you like memorize stuff better if anything(?)

@eoineoineoin
Copy link
Contributor

Minor quibble, when all names in a department are filtered out, the header for that department is still drawn, but empty.

2024-09-04_15-21

Could you possibly shuffle the code around so the departmentLabel is only added to the SensorsTable if there's at least one non-filtered sensor?

@slarticodefast slarticodefast added the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Sep 16, 2024
@slarticodefast slarticodefast added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Sep 19, 2024
Co-authored-by: slarticodefast <[email protected]>
@slarticodefast slarticodefast merged commit 854bfd2 into space-wizards:master Sep 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. Status: Needs Review This PR requires new reviews before it can be merged. Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants