Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examining now shows Coords on Handheld GPS, Coord readout update frequency increased #31814

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ArchRBX
Copy link
Contributor

@ArchRBX ArchRBX commented Sep 4, 2024

About the PR

Examining a Handheld GPS now displays its Coords.

The Coordinate readout on the GPS now updates every 0.35s. (1.5s -> 0.35s)

Why / Balance

Navigation with a GPS in space currently necessitates that you either have:

  • GPS in one hand, PKA/fire extinguisher/throwables in another. Can't carry people/machines
  • GPS in one hand, jetpack in backpack slot. No backpack means you can only really carry one thing
  • GPS in one hand, mini jetpack in your belt slot. Very limited capacity, not as readily available

If you deviate from these setups, for example if you're trying to transport things while travelling through space, you have to awkwardly drop and pickup things in order to read your GPS and navigate. Being able to examine your GPS lets you keep it in your pocket as a quick reference for navigation, instead of having to awkwardly drop and juggle things while floating through space.

The delay on coordinates updating didn't serve to add any fun challenge to navigation. Navigation is still just as difficult with this change, as you require the coordinates for the locations you're trying to reach, and need to be able to make sense of your heading and velocity on the fly. This information requires coordination with others or specialised equipment to obtain.

Technical details

Refactors the Handheld GPS to be largely handled in Shared.

Media

image

Content.Client_2024-09-15_19-09-57.mp4

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

  • SharedHandheldGPSComponent merged into to HandheldGPSComponent, moved to Shared
  • namespace Content.Client.GPS.Components changed to Content.Shared.GPS.Components

Changelog

🆑

  • add: Handheld GPS's can now be examined to read their displays
  • tweak: Handheld GPS's now update their displays much more frequently

Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great! Basically all the issues are formatting stuff 👍

Content.Shared/GPS/Systems/HandheldGpsSystem.cs Outdated Show resolved Hide resolved
Content.Shared/GPS/Systems/HandheldGpsSystem.cs Outdated Show resolved Hide resolved
Content.Shared/GPS/Systems/HandheldGpsSystem.cs Outdated Show resolved Hide resolved
Content.Shared/GPS/Components/HandheldGPSComponent.cs Outdated Show resolved Hide resolved
Content.Shared/GPS/Components/HandheldGPSComponent.cs Outdated Show resolved Hide resolved
Content.Client/GPS/Systems/HandheldGpsSystem.cs Outdated Show resolved Hide resolved
Content.Shared/GPS/Components/HandheldGPSComponent.cs Outdated Show resolved Hide resolved
Content.Shared/GPS/Components/HandheldGPSComponent.cs Outdated Show resolved Hide resolved
Content.Shared/GPS/Components/HandheldGPSComponent.cs Outdated Show resolved Hide resolved
Content.Shared/GPS/Components/HandheldGPSComponent.cs Outdated Show resolved Hide resolved
@deltanedas deltanedas mentioned this pull request Sep 14, 2024
2 tasks
@metalgearsloth metalgearsloth added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Sep 15, 2024
@ArchRBX
Copy link
Contributor Author

ArchRBX commented Sep 15, 2024

Changed PR scope slightly after discussing the issues with implementation with @PJB3005. Should hopefully resolve the changes requested, though does change the balance of the GPS.

@ArchRBX ArchRBX changed the title Examining now shows Coords on Handheld GPS Examining now shows Coords on Handheld GPS, Coord readout update frequency increased Sep 15, 2024
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Sep 15, 2024
@ArchRBX ArchRBX mentioned this pull request Sep 16, 2024
2 tasks
@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 24, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 24, 2024
@superjj18
Copy link
Contributor

Does this work on AstroNav PDAs?

@ArchRBX
Copy link
Contributor Author

ArchRBX commented Oct 1, 2024

Does this work on AstroNav PDAs?

Yes! I made the AstroNav with this PR in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants