-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examining now shows Coords on Handheld GPS, Coord readout update frequency increased #31814
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works great! Basically all the issues are formatting stuff 👍
Changed PR scope slightly after discussing the issues with implementation with @PJB3005. Should hopefully resolve the changes requested, though does change the balance of the GPS. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Does this work on AstroNav PDAs? |
Yes! I made the AstroNav with this PR in mind. |
About the PR
Examining a Handheld GPS now displays its Coords.
The Coordinate readout on the GPS now updates every 0.35s.
(1.5s -> 0.35s)
Why / Balance
Navigation with a GPS in space currently necessitates that you either have:
If you deviate from these setups, for example if you're trying to transport things while travelling through space, you have to awkwardly drop and pickup things in order to read your GPS and navigate. Being able to examine your GPS lets you keep it in your pocket as a quick reference for navigation, instead of having to awkwardly drop and juggle things while floating through space.
The delay on coordinates updating didn't serve to add any fun challenge to navigation. Navigation is still just as difficult with this change, as you require the coordinates for the locations you're trying to reach, and need to be able to make sense of your heading and velocity on the fly. This information requires coordination with others or specialised equipment to obtain.
Technical details
Refactors the Handheld GPS to be largely handled in Shared.
Media
Content.Client_2024-09-15_19-09-57.mp4
Requirements
Breaking changes
Changelog
🆑