Adds real-time charge & disabled action information to Actions #31821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cooldowns and charged update in real time. Sets Icon color to Disabled Icon Color or Original Icon color when action is updatees in shared. Adds method to check IsCoolDownActive and if we ShouldReesetCharges
…etCharges, adds bools to check if we should dirty or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds real-time charge & disabled action information to Actions
Why / Balance
It's better to see if your action is currently disabled in real time and the same for charges.
Technical details
Original Icon Color and Disabled Icon Color were added to the Base Action Component.
Original Icon Color is set on map init in SharedActionsSystem.
Action Icon Color gets set to either the Disabled Icon Color or the Original Icon Color depending if there's any charges & if the action is disabled in the Shared Actions System
States for Original icon Color and Disabled Icon Color were added to the Base Action Component, Action Component States, and the Client Action System.
Update was added to the shared actions system so we can Update & Dirty Actions if they're in the middle of a cooldown & are recharging.
Media
Content.Client_kxA3qARrNA.mp4
Requirements
Breaking changes
BaseActionComponent - OriginalIconColor and DisabledIconColor were added to the BaseActionComponent and the Action State.
SharedActionSystem - setting action.IconColor happens now in the UpdateAction() method. Update was added for all 3 action types so charge information & if the action is disabled can be updated in real time.
Changelog
tweak: Actions with charges will now grey out when they're disabled.