Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Emergency Access + Sound #31875

Closed
wants to merge 11 commits into from
Closed

Conversation

ScarKy0
Copy link
Contributor

@ScarKy0 ScarKy0 commented Sep 5, 2024

About the PR

AI can now set Emergency Access on doors.
Toggling emergency access now makes a sound.
Door Bolt and Emergency Access actions have a cool icon now too.
Doors cannot be bolted/unbolted while unpowered anymore.
AirlockComponent now has EmergencyOffSound and EmergencyOnSound.

Why / Balance

Adding missing features and I think there should be a sound for emergency access.

Technical details

Basically copy-pasted code from the bolting part except uses a different component.
Updated ToggleEmergencyAccess to take Entity, EntityUid? user and bool predicted as variables.

Media

8mb.video-nZV-jkgPo6S8.mp4

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Updated ToggleEmergencyAccess to take Entity, EntityUid? user and bool predicted as variables.

Changelog

🆑

  • add: AI can now toggle emergency access.
  • add: Emergency Access toggle now makes a sound.
  • tweak: Doors can no longer be bolted while unpowered.
  • add: Door Bolt AI action now has an icon.

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. labels Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

RSI Diff Bot; head commit 2452a32 merging into 44d3e3c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Actions/actions_ai.rsi

State Old New Status
bolt_door Added
emergency_off Added
emergency_on Added
unbolt_door Added

Edit: diff updated after 2452a32

@ScarKy0 ScarKy0 changed the title Updated AI Radial icons + Emergency Access toggle Updating the AI Radial menu. Sep 6, 2024
@ScarKy0 ScarKy0 marked this pull request as draft September 6, 2024 16:38
@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 6, 2024

Turning this into a draft until It's finished.

@ScarKy0 ScarKy0 marked this pull request as ready for review September 6, 2024 19:14
@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 6, 2024

I dont have the strength to keep trying to make this work
If someone wants to make the electrocute action I have a backup of it, ping me on the ss14 discord ill happily send it
It only needs to check if a power wire is cut and make you unable to toggle electrocute on a door if it is and its done

@ScarKy0 ScarKy0 changed the title Updating the AI Radial menu. AI Emergency Access + Sound Sep 6, 2024
@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 10, 2024

Moved to #32012

@ScarKy0 ScarKy0 closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant