Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cauterization spam from space damage #32080

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

themias
Copy link
Contributor

@themias themias commented Sep 11, 2024

About the PR

This PR sets a small threshold for playing the cauterization sound/popup. (You still receive the tiny amount of bloodloss reduction.)

Fixes #31827

Why / Balance

Tiny amounts of heat damage do almost nothing stop your bleeding and can cause a lot of spam of the noise/popup. Instead of providing useful feedback to the player, it's annoying and can cover up more useful sounds or popups.

Media

fix-cauterization-spam-demo.mp4

Requirements

Changelog
🆑

  • fix: Very small amounts of heat damage no longer play the cauterization sound (e.g. spacing)

@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Sep 11, 2024
@UbaserB
Copy link
Member

UbaserB commented Sep 11, 2024

this is amazing

@slarticodefast
Copy link
Member

Good idea, thanks for the fix!

@slarticodefast slarticodefast merged commit f2f76f7 into space-wizards:master Sep 11, 2024
13 checks passed
@themias themias deleted the fix-cauterize-spam branch September 11, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Being in space spams the wound burning message
3 participants