Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setmapatmos console command now can actually set temprature for map atmosphere to value from arguments #32125

Merged

Conversation

Fildrance
Copy link
Contributor

@Fildrance Fildrance commented Sep 13, 2024

About the PR

fixed 'setmapatmos' command to actually set map atmos temprature from command arguments

Why / Balance

Previously it was picking min from argument and min space tempratrue.

Technical details

none

Media

Sorry for media from russian client - wizden does not have easily accessable planetary maps : >

fix_setmapatmos_command.webm

Requirements

Breaking changes

none
Changelog

🆑
ADMIN:

  • fix: The setmapatmos command now correctly uses its temperature argument

@Fildrance
Copy link
Contributor Author

not adding anything to change log as it is admin only change

@Fildrance Fildrance marked this pull request as ready for review September 13, 2024 16:34
@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Sep 13, 2024
@slarticodefast
Copy link
Member

You can add an admin only changelog for this. See the PR guidelines for an example how to do that.

@Partmedia Partmedia merged commit 115ed0c into space-wizards:master Sep 13, 2024
24 checks passed
@Fildrance Fildrance deleted the feature/fix-setmapatmost-command branch September 14, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants