Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AreaInsert pickups for one item #32153

Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Sep 14, 2024

About the PR

Mirror of new-frontiers-14/frontier-station-14#2005

Allows entities with StorageComponent and AreaInsert set to pick up item sets with one item in range by clicking on the floor.

Why / Balance

Seems odd, comment implies it's a bug.

Technical details

Spawn trashbag.
Spawn trash.
Stand near the trash, click on the floor.
Trash should be picked up.

Media

2024-09-13.16-21-12.mp4

Requirements

Breaking changes

Changelog

🆑 whatston3

  • fix: Area insert items can pick up single item sets when clicking on the floor.

@metalgearsloth
Copy link
Contributor

Do you have evidence of this being relicensed as MIT?

@metalgearsloth metalgearsloth added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Sep 14, 2024
@lzk228
Copy link
Contributor

lzk228 commented Sep 14, 2024

Do you have evidence of this being relicensed as MIT?

it's literally one-liner (one-symbol, to be precise) that anyone other can come up with from their head
and it wasn't merged into frontier when the same author opened this pr, so this is just stupid to ask such questions

@metalgearsloth
Copy link
Contributor

Do you have evidence of this being relicensed as MIT?

it's literally one-liner (one-symbol, to be precise) that anyone other can come up with from their head and it wasn't merged into frontier when the same author opened this pr, so this is just stupid to ask such questions

Frontier has complained about this in the past so this is a valid question and not "stupid" as you insinuate.

@dvir001
Copy link
Contributor Author

dvir001 commented Sep 14, 2024

We want to have this fixed on upstream so we can have the same logical bug fix to the issue,
I merged it into Frontier after I opened it here so it can be fixed please.

Bug fixes should never be a "Frontier only" code when they effect everyone.

@whatston3
Copy link

As the writer of this change, I'm sure relicensing under MIT is fine. No concerns from my side, at the very least.

@slarticodefast slarticodefast merged commit 50395e2 into space-wizards:master Sep 24, 2024
12 checks passed
@slarticodefast
Copy link
Member

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants