Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syndicate business card #32162

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

pofitlo-Git
Copy link

@pofitlo-Git pofitlo-Git commented Sep 14, 2024

About the PR

A new uplink item is added to the game - the syndicate's business card. in general, it is quite useless and is only needed for role play. You can write a message on the back

Technical details

it costs nothing, but it is limited in purchase. you can only buy 3 of them

Media

image
image

Requirements

Breaking changes

Changelog

@pofitlo-Git pofitlo-Git marked this pull request as draft September 14, 2024 17:47
@github-actions github-actions bot added No C# For things that don't need code. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. labels Sep 14, 2024
@UbaserB
Copy link
Member

UbaserB commented Sep 14, 2024

This is so based

Copy link
Contributor

github-actions bot commented Sep 14, 2024

RSI Diff Bot; head commit 56fce5f merging into c1243a6
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Misc/bureaucracy.rsi

State Old New Status
synicate_card Added

Edit: diff updated after 56fce5f

@pofitlo-Git pofitlo-Git marked this pull request as ready for review September 14, 2024 23:31
@HenhenIII
Copy link

Based

@slarticodefast slarticodefast added the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Sep 15, 2024
@slarticodefast
Copy link
Member

slarticodefast commented Sep 18, 2024

The default isn't centered at the moment like in the PR image. You can add some whitespace to the ftl string using
{" "}
Also please add an changelog to your PR description to notify players of your addition (looks like it is inside a comment block and therefore invisible).

@slarticodefast slarticodefast added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Sep 18, 2024
@slarticodefast
Copy link
Member

Also a request from one of our art directors for the item sprite:
"make sure the item isnt in 3/4ths, is really all i have to say. goes against the artstyle guidelines im pretty sure.
the sprite could maybe use some rounded edges to make it more card-like, too"

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 20, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@slarticodefast
Copy link
Member

Test fail is real.
Also I will ask the art directors for approval of the new sprite.

@pofitlo-Git
Copy link
Author

Test fail is real. Also I will ask the art directors for approval of the new sprite.

it's because any "paper" sould have "write" state with sprite. And I don't know exactly how resolve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Merge Conflict This PR currently has conflicts that need to be addressed. No C# For things that don't need code. Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants