Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generator scrap (Plasma / uranium scrap) #32198

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

beck-thompson
Copy link
Contributor

About the PR

Added 6 new scraps that can be found when doing salvage! All are related to generators. The generators cannot be put in lockers so they have to be dragged back to the station. Because of this, they hold a lot of resources (45 steel, 5 or 30 plasma/uranium, 5 plastic)! These shouldn't be supper common but should appear about once per trip.

Why / Balance

Right now, its difficult to obtain any reasonable amount of plasma or uranium from salvage scrapping. This adds a few options that will hopefully make it easier.

Technical details

Media

2024-09-14.22-35-10.mp4

Changelog

🆑 Beck Thompson

  • add: Added some new scrap that contains uranium and plasma that can be found when salvaging!

@github-actions github-actions bot added No C# For things that don't need code. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. labels Sep 16, 2024
Copy link
Contributor

github-actions bot commented Sep 16, 2024

RSI Diff Bot; head commit 9cc2861 merging into c4d12df
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Materials/Scrap/generator.rsi

State Old New Status
generator_frame Added
nothing Added
old_generator_plasma Added
old_generator_plasma_fuel_leak Added
rad_dripping Added
rad_outline Added
red_x Added
uranium_generator Added
uranium_generator_fuel_tank Added

Edit: diff updated after 9cc2861

@beck-thompson
Copy link
Contributor Author

image

Forgot the shading!

- id: ScrapGeneratorPlasma
weight: 0.5
- id: ScrapGeneratorUranium
weight: 0.5
Copy link
Contributor

@Blackern5000 Blackern5000 Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the ones worth less plasma/uranium less common than the ones that give full stacks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted them to be less common! I think it would be better for the higher plasma/uranium generators to appear more frequently.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted them to be less common! I think it would be better for the higher plasma/uranium generators to appear more frequently.

More valuable things are rarer because you want them more, I don't think it makes much sense to have the less valuable version be less common, especially with just how much material you get from the filled generator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember this is scrap so being in better condition would make it less common (The two leaking ones are in much worse condition). Secondly, the other two generators are not very good so making them more common wouldn't be that helpful. Having to drag something that big for only 45 metal, 5 plastic, and 5 special is probably not worth it (At least when I'm doing salvage).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having to drag something that big for only 45 metal, 5 plastic, and 5 special is probably not worth it (At least when I'm doing salvage).

If you're exclusively dragging with a fire extinguisher, yeah it might not be worthwhile, but it's very common for salvage to build a lattice bridge or have fultons, which makes it very easy to gather most or all of the scrap on a debris regardless of transportation difficulty.
What if you increased the value of the leaking one a bit, and decrease the value of the intact one? I feel bringing them a bit closer (maybe 10/20 or 12/20 for leaking/intact) would work out well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry forgot reply but yeah that makes sense! Tweaking the values to basically that now

- type: PhysicalComposition
materialComposition:
Steel: 4500 # 45 sheets
Uranium: 3000 # 30 sheets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a LOT of material for a single loot item, even if it doesn't fit in a locker/crate. This will definitely end up with cargo being overstocked in plasma/uranium compared to gold/silver.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I duno... Again, these aren't super common so you should probably get ~1 per structure. If your going for plasma, there is only a 50% chance the generator is plasma, and then ~1/3 chance its one of the generators without a lot of resources in it. You also don't get any jetpacks, ships, or futons, so bringing it back is going to be a big pain. Honestly, from what I see from salvage they probably wont even bother to bring these back most of the time!

I feel like its kind of something we would need to see in game to really see if its too powerful. Knowing what salvage will do or not do is difficult 😆

@UbaserB UbaserB added the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Sep 22, 2024
Copy link
Member

@UbaserB UbaserB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it so that the empty frame version has depth? You should be able to see the bottom base of the generator a bit like you know, the sprite is somewhat angled. Also, if you're going to animate the uranium then maybe animate the plasma leakage too.

@UbaserB UbaserB added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Sep 23, 2024
@beck-thompson
Copy link
Contributor Author

Also, if you're going to animate the uranium then maybe animate the plasma leakage too.

I was thinking the plasma was more of a solid... I tried a few ways of animating it like with sparkles but I could never get it to look good :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# For things that don't need code. Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants