Cargo Gift Event: Add chance for toy boxes, party supplies, art supplies, variety instrument crates or plushie crates #32228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e chars to read better when game rule is added
|
Fixed the issue I was having with the exception, also added some minor character changes for gift descriptions to read better when it triggers |
TheShuEd
reviewed
Sep 18, 2024
| parent: CargoGiftsBase | ||
| components: | ||
| - type: StationEvent | ||
| weight: 3 |
There was a problem hiding this comment.
it will make the likelihood of useful gifts falling out much less likely.
There was a problem hiding this comment.
These are more meant to be fun additions rather than specifically be useful; what should they be weighted instead?
|
Can you make your PR description and changelog a little more descriptive than "fun"? Mention what crates and the event they are gifted in. |
august-sun
changed the title
Done! |
slarticodefast
added
the
Undergoing Maintainer Discussion
|
Closing until this is ready with more to add! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Added the chance for crates of toys, party supplies, art supplies, instruments or plushies to be gifted to the station!
Why / Balance
Fun gift crates for fun crews!
Technical details
Edited cargo_gifts.yml and cargo-gifts.ftl to match.
Media
Requirements
Breaking changes
Changelog
🆑