Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rat kings can butcher things #32232

Merged
merged 4 commits into from
Sep 21, 2024

Conversation

Plykiya
Copy link
Contributor

@Plykiya Plykiya commented Sep 17, 2024

About the PR

Rat kings have gained the ability to butcher animals and clothes

Why / Balance

I noticed there were some rat kings who were hunting the kitchen animals but were incapable of actually butchering them to eat them. This helps them out a bit.

Rats butchering Rats
Yes, this does mean the rat kings can butcher their own rats, but I tested it locally to see if it was possible to go infinite.

After butchering all of my starting rats, I was not even capable of creating one new rat from the meat they gave me. Drinking blood was already nerfed quite a bit in previous PRs for the rat king as well so I doubt it will change much there.

Technical details

SharpSystem's butchering was updated to work without hands

The EntityUid being used to butcher is set to the item the user is holding, otherwise it'll try to set it to the user, and if that fails it'll just be the default

Media

2024-09-16.21-41-09.mp4

Requirements

Breaking changes

Changelog

🆑

  • add: The rat king is now capable of butchering things, like animals.

@DogZeroX
Copy link
Contributor

I wanted to give this ability to species/mobs with claws in general.

@Plykiya
Copy link
Contributor Author

Plykiya commented Sep 17, 2024

I wanted to give this ability to species/mobs with claws in general.

just give them the SharpComponent if this ever gets merged

@ps3moira
Copy link
Contributor

Wasn't there a PR that made it so there couldn't be self-sustaining rat kings feasting on there own blood? Wouldn't this undo that and cause the same balancing issue if they can butcher and eat their own rat servants

@Cojoke-dot
Copy link
Contributor

Wasn't there a PR that made it so there couldn't be self-sustaining rat kings feasting on there own blood? Wouldn't this undo that and cause the same balancing issue if they can butcher and eat their own rat servants

read pr description...

@ps3moira
Copy link
Contributor

Wasn't there a PR that made it so there couldn't be self-sustaining rat kings feasting on there own blood? Wouldn't this undo that and cause the same balancing issue if they can butcher and eat their own rat servants

read pr description...

2 am reading pr's :trollface:

@slarticodefast slarticodefast added the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Sep 18, 2024
@slarticodefast
Copy link
Member

slarticodefast commented Sep 21, 2024

butcher.mp4

Since you set NeedHand to false in the DoAfterArgs BreakOnDropItem and BreakOnHandChange no longer work.
Otherwise this got conceptual approval.

@slarticodefast slarticodefast added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Sep 21, 2024
@Plykiya
Copy link
Contributor Author

Plykiya commented Sep 21, 2024

butcher.mp4

Since you set NeedHand to false in the DoAfterArgs BreakOnDropItem and BreakOnHandChange no longer work. Otherwise this got conceptual approval.

tragedy

@slarticodefast slarticodefast merged commit 1b81ce4 into space-wizards:master Sep 21, 2024
11 checks passed
@Plykiya Plykiya deleted the rat-king-butcher branch September 21, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants