Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blindness, but different #32249

Conversation

notquitehadouken
Copy link
Contributor

@notquitehadouken notquitehadouken commented Sep 17, 2024

About the PR

Adds a trait that gives you complete blindness, but also very good spatial awareness.

You can only see a small area, but holding something like a blind cane increases this range.

Anything you walk close enough to will appear in your vision, but will disappear shortly after if it is not anchored.

You can tell what direction sounds come from, but you cannot tell how far away they are unless they are relatively close.

todo:

ez:

  • Fix being able to see through walls
  • Make the character movement not extremely jittery
  • Fix not being able to see the floor
  • Make holding a cane increase the range at which you can see
  • Fading out
  • Add being able to see sound
  • Trait (why did it take me so long to add this)
  • Fix the memory leaks

not ez:

  • Fix not being able to see walls
  • Figure out what is so fundamentally broken about walls that makes them completely invisible
  • Fix being able to right click and see things (w/o spritecomp.visible) (nvm there's no reason you can just walk over)
  • Make item throws make sense

Why / Balance

i think it's cool

Technical details

Media

What it looks like right now:

Space.Station.14.2024-09-19.16-44-52.online-video-cutter.com.mp4

Funny image of before I figured out how to not memory leak:
memory_leak

Requirements

Breaking changes

Changelog

🆑

  • add: Added a new trait for blindness that completely removes your sight, but still lets you see things as long as they're close enough.

@7-62x54r
Copy link

7-62x54r commented Sep 17, 2024

Maybe add a check for noises so those items are permanently visible while in vicinity? Vending machines and such, maybe moving objects as well (those who make footsteps at least, moonboots exclueded)
Also, blind cane could light up all items in vicinity for a duration, making it QoL feature for blind people like IRL. But that's probably out of scope of this PR as it has damage iirc

@notquitehadouken
Copy link
Contributor Author

notquitehadouken commented Sep 17, 2024

Maybe add a check for noises so those items are permanently visible while in vicinity? Vending machines and such, maybe moving objects as well (those who make footsteps at least, moonboots exclueded) Also, blind cane could light up all items in vicinity for a duration, making it QoL feature for blind people like IRL. But that's probably out of scope of this PR as it has damage iirc

sounds will Show Up with a certain icon, this will handle vending machines and other things that make sound (footsteps, guns, explosives, computers being used, talking (not whispering), things being thrown, things landing, etc)

blind cane will extend the range you can see while you're holding it (like 2x) When I Code It and nothing else

@southbridge-fur
Copy link
Contributor

I like this idea. I feel like the blind cane should give you good vision of the ground you're on. Maybe just highlight the nearby tile(s)?

@notquitehadouken
Copy link
Contributor Author

I like this idea. I feel like the blind cane should give you good vision of the ground you're on. Maybe just highlight the nearby tile(s)?

i have a fix in mind

@notquitehadouken
Copy link
Contributor Author

notquitehadouken commented Sep 18, 2024

by the way the way seeing sound will work is leeching off of whatever event fires when a sound plays and using that

and also adding more data to sounds

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 19, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@notquitehadouken
Copy link
Contributor Author

crisis averted

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 19, 2024
@notquitehadouken
Copy link
Contributor Author

as it turns out there is no event that fires when a sound plays
this may be a problem

@notquitehadouken
Copy link
Contributor Author

ok i fixed the problem

@github-actions github-actions bot added the Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. label Sep 26, 2024
Copy link
Contributor

RSI Diff Bot; head commit 485507e merging into 937940b
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Effects/sound.rsi

State Old New Status
sound Added

@notquitehadouken
Copy link
Contributor Author

yar har

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 28, 2024
@notquitehadouken
Copy link
Contributor Author

i give up there's too many memory leaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Shaders Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Merge Conflict This PR currently has conflicts that need to be addressed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants