Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craftable explosion resistant closet :33 #32270

Closed
wants to merge 3 commits into from

Conversation

Thinbug0
Copy link
Contributor

@Thinbug0 Thinbug0 commented Sep 18, 2024

About the PR

Added a craftable explosion resistant closet
(my editing program chomped the quality on the lil silly showcase video, sorry qvq)

Why / Balance

Its usage is pretty situational, but at the moment the average crew has no way to protect themselves from explosions. This closet would give them a small bit of safety, specially for storing jugs
Not a lockable closet to prevent some goober hop from metagaming and replacing their locker with it

Technical details

Added 4 sprites and the ClosetBlast entity on closets.yml below the bomb suit closet, then some other stuffies so it can be crafted

Media

https://github.com/user-attachments/assets/4fd84659-aac0-4119-b710-886e742ad217
showRecipe2
showSprite

Wanted to give some old reliable yet improvised and low tech vibes, while still feeling bulky and strong

Requirements

Breaking changes

Changelog

🆑

  • add: Added a recipe for explosion resistant closets!

@github-actions github-actions bot added No C# For things that don't need code. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. labels Sep 18, 2024
Copy link
Contributor

github-actions bot commented Sep 18, 2024

RSI Diff Bot; head commit ff01cb5 merging into a123791
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Storage/closet.rsi

State Old New Status
blast Added
blast_door Added
blast_icon Added
blast_open Added

Edit: diff updated after ff01cb5

@tutoumi
Copy link

tutoumi commented Sep 18, 2024

I think you should replace steel by plasteel to make it rarer and more "realistic ?"

@Thinbug0
Copy link
Contributor Author

I think you should replace steel by plasteel to make it rarer and more "realistic ?"

that may be needed, but for how gimmicky its usage is i didnt wanna make it too annoying to craft

@slarticodefast
Copy link
Member

Medical should not store jugs in a closet in the first place. This is treating the symptom, not the problem. It would be better to rework the smart fridge to be actually usable in my opinion.

Also your changelog is formatted wrong.

@Thinbug0
Copy link
Contributor Author

Thinbug0 commented Sep 18, 2024

Medical should not store jugs in a closet in the first place. This is treating the symptom, not the problem. It would be better to rework the smart fridge to be actually usable in my opinion.

Also your changelog is formatted wrong.

what would be a more proper format for it? still struggling with that part (thought of it being "Added a recipe for..." or "name can now be crafted!" instead but wanted to be more consistent with previous pr's changelogs)

and yeah if i was competent enough i would try doing something more fundamentally helpful with the smartfridge, but i dont got enough practice on this to tackle the issue itself

@thebadman4662
Copy link

Problem is CMOs(EA on every door including CHEMLAB my beloathed) and doctors being dumbassess, medbay have doors and rooms for a reason. Threat of tiders and clowns already is enough to keep juglocker out of ward. Bottles exist for a reason too, though on some maps you gotta raid other departments to have enough glass.

And even if medbay bombing happens, its on chemists to keep backups so doctors are not back to topicals age.

@slarticodefast
Copy link
Member

what would be a more proper format for it? still struggling with that part (thought of it being "Added a recipe for..." or "name can now be crafted!" instead but wanted to be more consistent with previous pr's changelogs)

It has to be formatted like in the PR template so that the bot can read and add it to the in-game changelog (you need the - add: part in a new line). Your choice of words is fine.

grafik

@slarticodefast
Copy link
Member

and yeah if i was competent enough i would try doing something more fundamentally helpful with the smartfridge, but i dont got enough practice on this to tackle the issue itself

Bottles exist for a reason too, though on some maps you gotta raid other departments to have enough glass.

Yeah, I'm not an expert on UI design either, but maybe the smart fridge should be able to store jugs similar to how the chem dispenser does it and be able to dispense bottles filled with the reagent of your choice by clicking a button in a menu. Each doctor could then carry a few of those in their belt. It could also allow to directly draw from the jugs with a syringe.

@Thinbug0
Copy link
Contributor Author

what would be a more proper format for it? still struggling with that part (thought of it being "Added a recipe for..." or "name can now be crafted!" instead but wanted to be more consistent with previous pr's changelogs)

It has to be formatted like in the PR template so that the bot can read and add it to the in-game changelog (you need the - add: part in a new line). Your choice of words is fine.

grafik

oh whoops yeah i forgor about that, thankies

@Ilya246
Copy link
Contributor

Ilya246 commented Sep 18, 2024

could have just blast closet which costs steel/rods and reinforced blast closet which costs plasteel and is much tankier

perhaps make the reinforced version capable of (barely) surviving a nuke, except maybe not pointblank

@Everturning
Copy link

I wasn't even thinking about med I was thinking of nuke survival

@slarticodefast slarticodefast added the Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. label Sep 18, 2024
@Thinbug0
Copy link
Contributor Author

Thinbug0 commented Sep 19, 2024

After more coffee and thinking back on it yeah, it feels goofy and out of place for it to use normal steel, so swapped it with plasteel

Also yeah its most common usage would end up being for stuff like jugs, but i still think giving the average tider a way to deal a bit with explosions would be nice. Though at the moment the resistance isnt enough to protect small stuffies like glass, im not sure if giving it like a %99 resistance would be way too much

oki so did some testing and %99 is way too much, %96 seems to be a sweet spot where a meta glass would survive a c4, but at the same time thats enough for someone to closely survive a nuke with the closet and for what ive heard i dont think people want that to be possible e.e

@slarticodefast
Copy link
Member

Hey, I brought this up for maintainer vote and it was decided not to merge this for the reason already mentioned above. Med should not be encouraged to put a bomb-proof closet into their treatment room. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# For things that don't need code. Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants