Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore intern roles for traitor kill objective #32288

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lzk228
Copy link
Contributor

@lzk228 lzk228 commented Sep 18, 2024

image

About the PR

Intern, tech assist and research assist now can't be traitor kill objectives.

Why / Balance

to resolve #32271

Technical details

add new list of jobs in PickRandomPersonComponent
then for pick check if any of humans has the job in list
remove human from list

Media

Requirements

Breaking changes

Changelog

🆑

  • tweak: Medical intern, technical assistant and research assistant now can't be traitor kill objectives.

@beck-thompson
Copy link
Contributor

I always skip the objectives if its an intern as well. Really good idea!

@Cojoke-dot
Copy link
Contributor

Service worker needs to be added if that pr to make them an intern job ever gets merged...

@Boaz1111
Copy link
Contributor

intern should probably be clarified into medical intern in the CL, also, why does this not include cadets? Because they’re sec?

@lzk228
Copy link
Contributor Author

lzk228 commented Sep 18, 2024

why does this not include cadets? Because they’re sec?

you have to play 15 hours overall to play as cadet
also yes for me sounds weird that syndicate wouldn't want to kill security guys

@slarticodefast slarticodefast added the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Sep 18, 2024
@pheenty
Copy link

pheenty commented Sep 19, 2024

Add heads to this as well, heads should always fall under kill (not maroon) objective

@cohanna
Copy link
Contributor

cohanna commented Sep 19, 2024

Add heads to this as well, heads should always fall under kill (not maroon) objective

I don't see why?

@pheenty
Copy link

pheenty commented Sep 19, 2024

Add heads to this as well, heads should always fall under kill (not maroon) objective

I don't see why?

Because a couple of months ago antag difficulty has been correctly capped, but still one traitor can get "kill the RD and escape unrestrained" and the other can get something absurd like "kill or maroon the captain, kill or maroon the hos and escape unrestrained", because maroon objectives are considered easier (a maroon objective, say, a bartender, can die on their own and nobody would care, and in general killing a bartender is of course easier then a captain)

@Sarahon
Copy link
Contributor

Sarahon commented Sep 19, 2024

I don't really see it making much of a difference? If the person teaching the intern is the target, then the same issue persists? It's not like it's impossible to learn just because you're a possible target. The game overall just isn't really that beginner friendly and par for the course honestly.

Like you can make all intern roles non-targeted, but the person teaching them may be targeted, so teaching halts once again. At that point why not just make most, if not all service roles non-target since they're also usually where new players are recommended?

@Everturning
Copy link

At that point why not just make most, if not all service roles non-target since they're also usually where new players are recommended?

this is a false dichotomy, as even if new players are recommended to do service, that does not mean all service players are new players just because thats recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove intern roles from syndie kill objectives
10 participants