Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RGlass recipe for autolathe. Change remote controller category. #32305

Closed
wants to merge 2 commits into from

Conversation

VlaDOS1408
Copy link

About the PR

  • Add RGlass recipe for autolathe.
  • Change remote controller category from "Parts" to "Tools".

Why / Balance

I saw an issue in which a person complained about a broken recipe for reinforced glass in a vending machine (from ore) and asked me to make a recipe like in the crafting menu (G) but only immediately from steel in the vending machine (as it was before). So I did it. Well, I also just slightly changed the recipe ID (there are no errors) and changed the category of the signal transmitter to a more correct one.

Media

image
image

Requirements

Changelog
🆑

  • tweak: Remote signaller change lathe category from "Parts" to "Tools".
  • fix: Fixed RGlass recipe in autolathe. Now you can make reinforced glass from steel and glass there as before.

@github-actions github-actions bot added the No C# For things that don't need code. label Sep 19, 2024
@slarticodefast
Copy link
Member

Can you adjust the RemoteSignallerAdvanced as well? Also the category change won't need a changelog.

@slarticodefast slarticodefast added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Sep 21, 2024
result: SheetRGlass1
completetime: 0
materials:
RawQuartz: 100
RawIron: 50
RawIron: 40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you changing these? Now the price is different than the hand-crafted one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, coal is also used here. If you leave everything as it was, then the question arises: why the hell is it more expensive to melt reinforced glass than to assemble it by hand? How does it even work? Therefore, I lowered the cost.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will simply be unprofitable. So everyone will melt glass and steel separately, and then assemble in autolathe, well, or by hand.

Copy link
Member

@slarticodefast slarticodefast Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong, but the cost seems to be exactly the same to me:
In the ore processor:
0.5 steel + 1 glass = 50 raw iron, 15 coal + 100 raw quartz
1 reinf. glass = 50 raw iron, 15 coal, 100 raw quartz
hand crafting and the lathe:
1 reinf. glass = 0.5 steel + 1 glass
The coal cost is already used when producing the glass and steel from raw ores.
Directly producing it in the lathe or ore processor should not be profitable, but simply save you the additional crafting steps.

@@ -43,9 +43,25 @@
completetime: 2
materials:
RawQuartz: 3000
RawIron: 1500
RawIron: 1200
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@slarticodefast
Copy link
Member

Are you coming back to this?

@slarticodefast
Copy link
Member

Leave a comment when you want to continue working on this and I will re-open the PR.

@slarticodefast slarticodefast added the Status: Derelict This PR appears to be abandoned but might contain something that can be salvaged. label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# For things that don't need code. Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. Status: Derelict This PR appears to be abandoned but might contain something that can be salvaged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants