ID card computer bug fixed (And made it more fun!)

[beck-thompson]

About the PR

Bug reported on discord by Kaz!

When deconstructing the ID card computer, the inserted IDs would get deleted. I added the same component that machines use so this should fix any other bugs with computers deleting stuff (Although I think there aren't any currently?).

I also made the ID computer specifically throw the IDs out in a fun way instead of just dropping them. It also now ejects the IDs when damaged! See the video in the comments.

Media

2024-09-19.10-25-07.mp4

Changelog

🆑 Beck Thompson, Kaz Wooblie

• fix: Computers now wont delete items inside of them when deconstructing.
• add: The ID card computer now throws the IDs out when deconstructed or damaged!

[dvir001]

What about on destroy?

[lzk228]

• fix: Computers now wont delete items inside of them when deconstructing.

• add: The ID card computer now throws the IDs out when deconstructed!

i think the second line in cl really means the first, so you left only the first one

[beck-thompson]

i think the second line in cl really means the first, so you left only the first one

They are similar but not quite the same! This PR could technically just be a one line YMAL change (Adding the MachineDeconstructedEvent) but the default behavior is to just spawn the items right on top of the computer which isn't fun (But it does work). Adding that fixes the bug where it gets deleted!

The second part is the unique logic for only the ID computer (Other computers won't do this) which I make it spit out the ids randomly!

[beck-thompson]

What about on destroy?

I'm really busy right now but if isn't merged soon I'll add it! Sounds fun

[beck-thompson]

2024-09-21.00-15-36.mp4

[0x6273]

Why is eject on damage needed? I'm pretty sure you can get the IDs out if you right click, even if the computer is broken.

[beck-thompson]

Why is eject on damage needed? I'm pretty sure you can get the IDs out if you right click, even if the computer is broken.

Its fun

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[slarticodefast]

Its fun

Adjust your PR title and description for this please.
Also you just turned a quick bugfix PR into one in need of a three day maintainer dicussion due to gameplay changes 😄

[beck-thompson]

Also you just turned a quick bugfix PR into one in need of a three day maintainer dicussion due to gameplay changes 😄

Good I like giving more work to the maintainers 😈 😈 😈