Disable resizing of lobby character editor #32313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: UI
|
does it have something with #27650 ? |
Ilya246
pushed a commit
to Ilya246/space-station-14
that referenced
this pull request
Oct 7, 2024
No resizing character editor Co-authored-by: Eoin Mcloughlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Real trivial bugfix. When attempting to close the character editor, I misclicked and accidentally resized the character editor.
Once the editor has been resized, the container remembers the sizes until application restart, and when the user attempts to manually restore the size, it makes a mess of the main lobby screen.
There's no need for these controls to be user-resizable anyway, so just disable that.
Why / Balance
Technical details
Media
Old behaviour; character editor remembers a bad size and is broken whenever you open it:
Lobby after you attempt to resize the character editor back to what it was previously:
Bonus, stops this "resizable" mouse cursor from appearing, even though the panel couldn't be resized:
Requirements
Breaking changes
Changelog