Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update binary key to use AI icon #32327

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update binary key to use AI icon #32327

wants to merge 2 commits into from

Conversation

ScarKy0
Copy link
Contributor

@ScarKy0 ScarKy0 commented Sep 20, 2024

About the PR

Feature for #32326

Why / Balance

AI our beloved

Technical details

Added an ai_label to encryption keys.

Media

image

Requirements

Breaking changes

Changelog

🆑

  • tweak: Binary encryption key now uses an AI icon

@github-actions github-actions bot added No C# For things that don't need code. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. labels Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

RSI Diff Bot; head commit 54c957f merging into 6d5ac1e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Devices/encryption_keys.rsi

State Old New Status
ai_label Added

Edit: diff updated after 54c957f

@UbaserB UbaserB added the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Sep 20, 2024
@slarticodefast
Copy link
Member

the icon in the uplink should be adjusted as well then

@slarticodefast slarticodefast added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Sep 20, 2024
@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Sep 20, 2024

the icon in the uplink should be adjusted as well then

Oh I had no idea the uplink one has one to begin with

@slarticodefast slarticodefast removed the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Sep 20, 2024
@TheDoctor1977
Copy link

TheDoctor1977 commented Sep 20, 2024 •
edited
Loading

if you write "fixes #32326" in the original PR discussion post it'll automatically close the issue when this gets merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# For things that don't need code. Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScarKy0 @slarticodefast @TheDoctor1977 @UbaserB