Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localizable craftmenu #32339

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Ertanic
Copy link
Contributor

@Ertanic Ertanic commented Sep 20, 2024

About the PR

The name and description of the target crafting items are now taken directly from the prototypes.

Why / Balance

Technical details

Media

Requirements

Breaking changes

Changelog

  • tweak: The name and description of the target crafting items are now taken directly from the prototypes.

@slarticodefast
Copy link
Member

Wouldn't that cause problems with things like secret walls that have a different name?

@Ertanic
Copy link
Contributor Author

Ertanic commented Sep 20, 2024

Wouldn't that cause problems with things like secret walls that have a different name?

Very likely. But exactly the secret door in the prototype itself is referred to as a solid wall.

image

@slarticodefast
Copy link
Member

Yeah, that's a problem, you won't know which one is which if you don't know the recipe. Maybe add an optional translation string to the crafting menu entry that overrides the prototype name if necessary.

@chavonadelal
Copy link
Contributor

chavonadelal commented Sep 20, 2024

Yeah, that's a problem, you won't know which one is which if you don't know the recipe. Maybe add an optional translation string to the crafting menu entry that overrides the prototype name if necessary.

No, I don't think that's an option! Localization could be ruined again... Although, only if it's LocID, then maybe...

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Sep 21, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Conflict This PR currently has conflicts that need to be addressed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants