Criminal Records Computer Better UX + Filtering #32352

jamessimo · 2024-09-21T15:14:42Z

About the PR

Updated the criminal records computer to have some new features, these are;

Show crews jobs and job icon
Show criminal status icon
Allow for multiline wanted and suspect reasons
Ability to filter the criminal record types
Fixed a bug where "Suspect" and "Wanted" where used incorrectly.
Tweaks to the UI

Why / Balance

When you are joining mid round, there is no way to know who is wanted/detained and on parole unless you manually click through the criminal records. This allows new officers to quickly catch up on whos wanted and for what. Also nice to see jobs because a name would be wanted but no indication of what there job is.

Technical details

Added a new CriminalRecordSetStatusFilter method, this is a int of 0 to 3 which is mapped to CriminalRecord.Status. Also removed some hard coded colors in the locals file.

Orginally this used tabs but the tabs were not the correct method since I didn't want a completely new UI per tab and just needed to filter the stations records according to their criminal record status.

I accidently included a .vscode config file, didn't notice until now and not sure if that will cause an issue.

Media

Requirements

I have read and am following the Pull Request and Changelog Guidelines.
I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

tweak: Criminal Records computer got enhanced UX & UI
tweak: Criminal Records computer can now filter its list against crew criminal status

need buttons to highlight.

Moomoobeef · 2024-09-21T17:53:31Z

you could add a print button and a dropdown to have criminal records be printable to a fax machine, but that might be out of scope for this PR.

thebadman4662 · 2024-09-21T18:48:22Z

When you are joining mid round, there is no way to know who is wanted/detained and on parole unless you manually click through the criminal records.

Small correction here, we now have wanted lists in PDA showing only criminals, their age, species and job on top of their status. But of course even better criminal records never hurt.

jamessimo · 2024-09-22T00:10:27Z

you could add a print button and a dropdown to have criminal records be printable to a fax machine, but that might be out of scope for this PR.

That was on my plate to do and I even designed it but getting the filtering to work took way too much time. I will make another PR later with that and embed the crime history onto the main console window as outlined in #24646

ArchRBX

Code looks good to my eyes, just some unclear comments and unnecessary files included.

.vscode/launch.json

Content.Server/CriminalRecords/Systems/CriminalRecordsConsoleSystem.cs

jamessimo · 2024-09-28T23:35:53Z

Pretty sure I fixed all the issues. Please let me know if anything needs to change.

Content.Client/CriminalRecords/CriminalRecordsConsoleWindow.xaml.cs

Loc NA and use inject deps Cannot use inject deps on sprite system.

jamessimo · 2024-10-15T10:54:46Z

Just wanted to poke and say this PR has no outstanding issues.

superjj18 · 2024-10-15T12:05:18Z

Is there a way to search for people of a certain job?

if someone screams “a chef just freakin STABBED ME” it would make it easier to narrow down the suspects.

would very much help AI who doesn’t have access to the manifests

jamessimo · 2024-10-18T04:18:08Z

Is there a way to search for people of a certain job?

if someone screams “a chef just freakin STABBED ME” it would make it easier to narrow down the suspects.

would very much help AI who doesn’t have access to the manifests

I could. I would add that into the next version which will have printing pages and showing crime history at all times. don't want to add more to this PR still hasn't been pulled for a month so adding more will only delay it.

jamessimo · 2024-11-01T09:32:21Z

Just another bump to say this PR is good to go in my eyes.

chromiumboy · 2024-11-11T21:35:44Z

Thanks for this, I'll review it a bit later

chromiumboy

I really like the changes to the UI you've made, it's a big improvement.

chromiumboy · 2024-11-12T04:27:36Z

.vscode/launch.json

@@ -52,4 +52,4 @@
            "preLaunchTask": "build"
        }
    ]
-}


Try re-adding the white space to remove the changes to this file. If the line endings have been changed, try this: https://ohshitgit.com/#undo-a-file

chromiumboy · 2024-11-12T04:31:38Z

Content.Shared/CriminalRecords/Components/CriminalRecordsConsoleComponent.cs

@@ -31,6 +31,13 @@ public sealed partial class CriminalRecordsConsoleComponent : Component
    [DataField]
    public StationRecordsFilter? Filter;

+    /// <summary>
+    /// Current tab of the filter by criminal status buttons.
+    ///


Suggested change

///

chromiumboy · 2024-11-12T04:33:22Z

Resources/ServerInfo/Guidebook/Security/CriminalRecords.xml

@@ -15,6 +15,8 @@

  - The criminal records themselves

+  - Filter buttons below the crew list to show only the wanted, detained or paroled crew.


Suggested change

- Filter buttons below the crew list to show only the wanted, detained or paroled crew.

- The filter button below the crew list can be used to show only wanted, detained, or paroled crew.

chromiumboy · 2024-11-12T04:43:07Z

Content.Server/CriminalRecords/Systems/CriminalRecordsConsoleSystem.cs

+        var statusMap = new Dictionary<int, SecurityStatus>
+        {
+            { 1, SecurityStatus.Wanted },
+            { 2, SecurityStatus.Paroled },
+            { 3, SecurityStatus.Detained }
+        };


This should be defined outside a function

chromiumboy · 2024-11-12T04:44:31Z

Content.Server/CriminalRecords/Systems/CriminalRecordsConsoleSystem.cs

@@ -28,7 +29,6 @@ public sealed class CriminalRecordsConsoleSystem : SharedCriminalRecordsConsoleS
    [Dependency] private readonly StationRecordsSystem _records = default!;
    [Dependency] private readonly StationSystem _station = default!;
    [Dependency] private readonly UserInterfaceSystem _ui = default!;
-


Unnecessary whitespace change

chromiumboy · 2024-11-12T04:50:35Z

Content.Client/CriminalRecords/CriminalRecordsConsoleWindow.xaml.cs

@@ -162,7 +211,7 @@ public void UpdateState(CriminalRecordsConsoleState state)
        }
    }

-    private void PopulateRecordListing(Dictionary<uint, string>? listing)
+    private void PopulateRecordListing(Dictionary<uint, string>? listing, SecurityStatus? filterSecStatus = null)


filterSecStatus appears to be unused

chromiumboy · 2024-11-12T04:55:42Z

Content.Client/CriminalRecords/CriminalRecordsConsoleWindow.xaml

+                       FontColorOverride="DarkGray" />
+                <!-- Selected record info -->
+                <BoxContainer Name="PersonContainer"
+                              Orientation="Vertical"


This container should expand when the window is resized

chromiumboy · 2024-11-12T04:57:37Z

Content.Client/CriminalRecords/CriminalRecordsConsoleWindow.xaml

+            <BoxContainer Margin="5 5 5 10"
+                          HorizontalExpand="true"
+                          VerticalAlignment="Center">
+                <OptionButton Name="FilterType"


Consider increasing the width of the filter button so it matches the width of the crew list below it

chromiumboy · 2024-11-12T05:01:20Z

Content.Client/CriminalRecords/CriminalRecordsConsoleWindow.xaml

+                              Margin="5 5 10 5"
+                              MinWidth="250"
+                              MaxWidth="250">
+                    <Label Name="RecordListingTitle"


A little extra whitespace to pad the title from the list below would be nice, plus maybe increase the font size a little

chromiumboy · 2024-11-12T05:06:48Z

Content.Client/CriminalRecords/CriminalRecordsConsoleWindow.xaml

-                <RichTextLabel Name="WantedReason" Visible="False"/>
-                <Button Name="HistoryButton" Text="{Loc 'criminal-records-console-crime-history'}"/>
+            </BoxContainer>
+            <BoxContainer Orientation="Horizontal"


I'd like to see this container shrunk down so it matches the width of the crew list above it. Consider using a drop-down list for the buttons (when these labels are translated into Russian, for example, they are quite long)

jamessimo added 2 commits September 19, 2024 23:08

First pass at new Criminal Records Computer

55c2ed6

need buttons to highlight.

Filter status tabs/buttons now activate correctly via UpdateState

78617e7

jamessimo requested a review from EmoGarbage404 as a code owner September 21, 2024 15:14

github-actions bot added Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Needs Review This PR requires new reviews before it can be merged. labels Sep 21, 2024

Removed unneeded Directives

a07509d

ArchRBX reviewed Sep 26, 2024

View reviewed changes

.vscode/launch.json Outdated Show resolved Hide resolved

Content.Server/CriminalRecords/Systems/CriminalRecordsConsoleSystem.cs Outdated Show resolved Hide resolved

Fix typo + undo VSCode changes

7f4a0da

metalgearsloth reviewed Oct 3, 2024

View reviewed changes

Content.Client/CriminalRecords/CriminalRecordsConsoleWindow.xaml.cs Outdated Show resolved Hide resolved

metalgearsloth reviewed Oct 3, 2024

View reviewed changes

Content.Client/CriminalRecords/CriminalRecordsConsoleWindow.xaml.cs Outdated Show resolved Hide resolved

slarticodefast added the Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. label Oct 3, 2024

Implement Emo Feedback

cb362bf

Loc NA and use inject deps Cannot use inject deps on sprite system.

Emisse requested a review from metalgearsloth October 18, 2024 08:03

chromiumboy self-assigned this Nov 11, 2024

chromiumboy requested changes Nov 12, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Criminal Records Computer Better UX + Filtering #32352

Criminal Records Computer Better UX + Filtering #32352

jamessimo commented Sep 21, 2024

Moomoobeef commented Sep 21, 2024 •

edited

Loading

thebadman4662 commented Sep 21, 2024

jamessimo commented Sep 22, 2024

ArchRBX left a comment

jamessimo commented Sep 28, 2024

jamessimo commented Oct 15, 2024

superjj18 commented Oct 15, 2024 •

edited

Loading

jamessimo commented Oct 18, 2024

jamessimo commented Nov 1, 2024

chromiumboy commented Nov 11, 2024

chromiumboy left a comment

chromiumboy Nov 12, 2024

chromiumboy Nov 12, 2024

chromiumboy Nov 12, 2024

chromiumboy Nov 12, 2024

chromiumboy Nov 12, 2024

chromiumboy Nov 12, 2024

chromiumboy Nov 12, 2024

chromiumboy Nov 12, 2024

chromiumboy Nov 12, 2024

chromiumboy Nov 12, 2024

		@@ -15,6 +15,8 @@

		- The criminal records themselves

		- Filter buttons below the crew list to show only the wanted, detained or paroled crew.

	- Filter buttons below the crew list to show only the wanted, detained or paroled crew.
	- The filter button below the crew list can be used to show only wanted, detained, or paroled crew.

Criminal Records Computer Better UX + Filtering #32352

Are you sure you want to change the base?

Criminal Records Computer Better UX + Filtering #32352

Conversation

jamessimo commented Sep 21, 2024

About the PR

Why / Balance

Technical details

Media

Requirements

Breaking changes

Moomoobeef commented Sep 21, 2024 • edited Loading

thebadman4662 commented Sep 21, 2024

jamessimo commented Sep 22, 2024

ArchRBX left a comment

Choose a reason for hiding this comment

jamessimo commented Sep 28, 2024

jamessimo commented Oct 15, 2024

superjj18 commented Oct 15, 2024 • edited Loading

jamessimo commented Oct 18, 2024

jamessimo commented Nov 1, 2024

chromiumboy commented Nov 11, 2024

chromiumboy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Moomoobeef commented Sep 21, 2024 •

edited

Loading

superjj18 commented Oct 15, 2024 •

edited

Loading