change ShowHealthBars and ShowHealthIcons to use protoId #32355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
SlamBamActionman
approved these changes
Nov 2, 2024
SlamBamActionman
added
the
PR: Approved
|
SALVATION |
|
Seems much more sane. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
use protoId
Why / Balance
qol for working with the fucking overlays
Technical details
Changes the ShowHealthBarsComponent and ShowHealthIconsComponent to use ProtoId and default to Biological (you can set it to anything else in yaml still, like with the diagnostic hud), changes the ShowHealthBarsCommand to work with ProtoId, yaml cleanup
Requirements
Breaking changes
none
Changelog