Add puddle drawdepth #32369
Open
Add puddle drawdepth #32369
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The y-fighting it hurts.
slarticodefast
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Gave it an in-game test and it will need some adjustments:
Since atmos devices now draw over puddles it causes problems for the pipes sticking out of them. Can the draw depth be set per layer? Also connector ports still draw below the puddle.
Ice crust and conveyors draw over puddles, which looks wrong.
A lazy solution for this might be to make puddles Default - 7 and FloorTiles Default - 6 so that puddles always draw over them.
| FloorTiles = DrawDepthTag.Default - 7, | ||
|
|
||
| // Discrete drawdepth to avoid y-fighting with other FloorObjects but also above floor entities. | ||
| Puddles = DrawDepthTag.Default - 6, | ||
|
|
||
| /// <summary> | ||
| /// Things that are actually right on the floor, like puddles. This does not mean objects like |
There was a problem hiding this comment.
Suggested change
| /// Things that are actually right on the floor, like puddles. This does not mean objects like | |
| /// Things that are actually right on the floor, like conveyor belts, ice crust or atmos devices. This does not mean objects like |
slarticodefast
added
the
Status: Awaiting Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The y-fighting it hurts.
🆑