-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flash reaction effect #32377
Add flash reaction effect #32377
Conversation
Make it use the flashbang sound effect, rather than the normal flash sound. It just fits better. |
chemical mix that requires you to flash it to mix... |
I was planning on also adding a sonic explosion reaction that makes you deaf for a while and add it to the flashbang. So I wanted to reserve the "bang" sound for that for consistency. But I agree the "click" sound in the flash is not perfect. Edit: I gave the flashbang sound effect a try and it does not really fit. Way too loud and more bang than flash. |
Just want to say that that this reaction basically guarantees gibbing via some rather easy mixes, on one hand it would be nice to have such infernal recipe for antag, on another only counterplay is to have flash protection at all times cause as soon as its mixed, you are as good as dead and you won't be able to escape which is pretty powerful for 0TC. |
You should add a sound that better reflects the powdery, chemical reaction that this is, instead of sounding like a camera flash. Here are some samples I quickly found on freesound, though there are more: https://freesound.org/people/Kinoton/sounds/468076/ They sound exactly like you would expect from this reaction, just need a little cropping. Perhaps they could be used as a pool of several variations instead of always the same sound. |
Uh, how does this interact with head revs? |
This is AOE and hrevs need direct attacks, splashing cryostasis mix applies touch effects rather than mixes, so nothing happens that way either. At best it just makes catching someone you want to convert easier. |
* Add flash reaction effect (space-wizards#32377) add flash reaction effect * Automatic changelog update * Fix loneop spawnrate by reverting it to not use the shuttle event system. (space-wizards#32942) Fix loneop spawnrate by reverting it to not use the custom shuttle event system. * Automatic changelog update * add atmosia to devmap (space-wizards#32460) change * bowls now make drinking sounds (space-wizards#32819) * Automatic changelog update --------- Co-authored-by: slarticodefast <[email protected]> Co-authored-by: PJBot <[email protected]> Co-authored-by: BramvanZijp <[email protected]> Co-authored-by: Ilya246 <[email protected]> Co-authored-by: Moomoobeef <[email protected]>
* Add flash reaction effect (space-wizards#32377) add flash reaction effect * Automatic changelog update * Fix loneop spawnrate by reverting it to not use the shuttle event system. (space-wizards#32942) Fix loneop spawnrate by reverting it to not use the custom shuttle event system. * Automatic changelog update * add atmosia to devmap (space-wizards#32460) change * bowls now make drinking sounds (space-wizards#32819) * Automatic changelog update * Add health analyzer unrevivability warning (space-wizards#32636) * Add health analyzer unrevivability warning * Remove errornous comment * Automatic changelog update * Removed the name "Hujsak" (space-wizards#32998) removed hujsak * Update Credits (space-wizards#33016) Co-authored-by: PJBot <[email protected]> * fix pie throwing sound not playing (space-wizards#33017) * Automatic changelog update --------- Co-authored-by: slarticodefast <[email protected]> Co-authored-by: PJBot <[email protected]> Co-authored-by: BramvanZijp <[email protected]> Co-authored-by: Ilya246 <[email protected]> Co-authored-by: Moomoobeef <[email protected]> Co-authored-by: Saphire Lattice <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
add flash reaction effect
About the PR
Adds the flash reaction effect from SS13 (see tg wiki).
1 aluminium
1 potassium
1 sulfur
The range scales with the reagent amount.
Why / Balance
Chemistry needs a few more fun reactions that are non-lethal.
Technical details
Adds a new entity effect that calls FlashArea.
It also spawns a disappearing pointlight prototype similar to that used by the flashbang for better visual feedback.
The pointlight is scaled in size according to the flash range.
Media
ss14.flash.reaction.mp4
(I accidentally had the dropper in draw mode, but you still see what happens)
Requirements
Breaking changes
none
Changelog
🆑