fix viewing nav slowing shuttle down #32381
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this should definitely be tested. |
|
this is salvaged from an earlier PR i abandoned and it was tested then but this exact PR is not tested and yes i'll test anyway just to be sure |
|
tested, works properly and fixes the issue |
|
quantum mechanics be like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
title, fixes the fact that a person simply viewing the shuttle nav console without any input would cause it to slow down
Why / Balance
just looking shouldn't make the shuttle slow down
Media
tested, works
Technical Details
made it actually count people with nonzero input and take into account
Requirements
Changelog
🆑