Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binary channel access to silicons without laws. #32385

Conversation

VasilisThePikachu
Copy link
Member

@VasilisThePikachu VasilisThePikachu commented Sep 22, 2024

About the PR

Remove binary channel access to silicons without laws.

Why / Balance

Mostly feature proofing but these should not have binary access. ESPECIALLY pais

Say we had malf ai and it was talking with other borgs about its plans. The owner of the pai (or any of these silicons) can just listen into this. Someone can just wake up a pai and ask it to monitor the binary channel. There's a reason the binary radio chip is a syndicate item.

Some of these also have no reason to be able to talk on binary, are you gonna ask the ai to bother someone to refill your vend stock? Are you gonna clown with the AI and other borgs as a clown borg and annoy them?

And the pai story can be repeated again, free binary access key.

Requirements

Breaking changes

MobSiliconBase no longer has a radio. It will need to be added to anything requiring it. Anything requiring it already has it added

Changelog

🆑 Myra

  • remove: Silicon with no laws will not have binary channel access.

Mostly feature proofing but these should not have binary access. ESPECIALLY pais

Say we had malf ai and it was talking with other borgs about its plans. The owner of the pai (or any of these silicons) can just listen into this. Someone can just wake up a pai and ask it to monitor the binary channel. There's a reason the binary radio chip is a syndicate item.

Some of these also have no reason to be able to talk on binary, are you gonna ask the ai to bother someone to refill your vend stock? Are you gonna clown with the AI and other borgs as a clown borg and annoy them?
@github-actions github-actions bot added the No C# For things that don't need code. label Sep 22, 2024
@VasilisThePikachu VasilisThePikachu added the Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. label Sep 22, 2024
@ScarKy0
Copy link
Contributor

ScarKy0 commented Sep 22, 2024

Me when my owner dies and im forced to just sit there in silence or /ghost

@Ilya246
Copy link
Contributor

Ilya246 commented Sep 22, 2024

i think all the things having binary channel adds to fun more than it offsets balance so it should be kept, and makes being said silicons at least somewhat less boring plus allow you to communicate remotely

from my own experience, pAI-borg binary channel interactions add quite a bit to fun and general interestingness of gameplay

@deltanedas
Copy link
Contributor

pais having binary would make malf impossible since any kind of order would immediately be snitched on and sec would raid the ai core

@Ilya246
Copy link
Contributor

Ilya246 commented Sep 22, 2024

pais having binary would make malf impossible since any kind of order would immediately be snitched on and sec would raid the ai core

then make all of those also obey ai

@Simyon264
Copy link
Contributor

I'd merge this once Malf AI is actually implemented. Currently cyborgs along with all other silicons act mostly independent of each other. Having played pAI a lot, there is a lot of fun to be had conversing with other pAIs and cyborgs. Being locked only to local chat sucks a lot and if this is merged pAI's need some sort of radio to continue being as fun as before.

@Golinth
Copy link
Contributor

Golinth commented Sep 22, 2024

I wholeheartedly agree with this. pAIs already make stealing PDAs or killing people far more risky than it should be (zero counterplay if the pAI stays quiet until they report you), and when malf AI comes it will be even worse. As much as it “makes sense” for machines to have access to the “machine chat”, for balance purposes they need to have it revoked

@PJB3005
Copy link
Member

PJB3005 commented Sep 22, 2024

I'd merge this once Malf AI is actually implemented.

image

It is. There is no reason to have this feature other than pissing on 20 years of SS13 hindsight.

@Simyon264
Copy link
Contributor

I'd merge this once Malf AI is actually implemented.

image

It is. There is no reason to have this feature other than pissing on 20 years of SS13 hindsight.

IIRC that board is not mapped anywhere currently. Also, malf AI has no real implementation beyond laws. There are no win conditions like with (as an example) nukies. A Malf AI cannot do anything to protect its laws from being changed again. One engineer is all it takes.

@PJB3005
Copy link
Member

PJB3005 commented Sep 22, 2024

IIRC that board is not mapped anywhere currently. Also, malf AI has no real implementation beyond laws. There are no win conditions like with (as an example) nukies. A Malf AI cannot do anything to protect its laws from being changed again. One engineer is all it takes.

I am sorry but this entire comment just does not understand how AI works in SS13. Just because "Malf AI" isn't a gamemode does not mean a subverted/hostile AI is not a game mechanic. It also does not matter how easily the AI can be reset, it can still do damage to players and the station in the mean time.

@Simyon264
Copy link
Contributor

not mean a subverted/hostile AI is not a game mechanic

It's a poorly implemented game mechanic for Station AI and limiting the binary channel in the current implementations will result in less RP and Gameplay; An overall worse experience.

@ArcaneOcto
Copy link

I think that these roles should have laws causing them to be loyal to the AI or something. I personally don't think removing the ability for pAIs to use Binary is a good idea. It's one of the few actually useful things you can do as a pAI. The AI and Borgs are arguably the most informed beings on the station, so being able to talk to them is very helpful to keep your owner informed. pAIs snitching on malf AI is definately something that needs to be fixed though.

@southbridge-fur
Copy link
Contributor

I want to echo what a lot of people are saying regarding how pAIs having binary access is pretty much one of their only features. I want to follow that up by adding that there is another human there, playing the pAI. If I'm the target of an antag or join late in observer I'd like to be able to have some kind of influence on the game. Even if that influence is basically a middle-man for the human I'm attached to I still get to have some fun.

I do agree though with the ideas I've seen in this and other PRs that add laws to pAIs, since that can add more dynamic interactions throughout a round.

@superjj18
Copy link
Contributor

Let's be real here this change is not a matter of if but when

@nymhole
Copy link

nymhole commented Sep 23, 2024

opposite, ADD LAWS TO PAI.

@superjj18
Copy link
Contributor

opposite, ADD LAWS TO PAI.

Already denied by maintainers

@nymhole
Copy link

nymhole commented Sep 23, 2024

opposite, ADD LAWS TO PAI.

Already denied by maintainers

that is so boring, and should be rediscussed considering silicon laws should sync with ai laws

because according to this PR fucking borgs shouldnt have access to the binary comms since they dont share the ai laws. this PR is working with the pretense that borgs share the AI's lawset which is just not true, and when that is true then PAI should have laws so that PAIs can keep what little functionality they have.

@PJB3005
Copy link
Member

PJB3005 commented Sep 23, 2024

Giving pAIs laws would literally go completely against the point of pAIs. They're supposed to be personal companions of a human, not servants of the station AI. Imagine your pAI you've been buddies with all shift having to shut up because the AI got subverted.

@ItsMeThom
Copy link
Contributor

how about giving pAIs a slot for installing comms keys, like a headset? So pAIs could be given say, a cargo or sec key by their owner and allowed to communicate over the frequencies with/for their owner?

@slarticodefast
Copy link
Member

This was brought up for maintainer vote and the unanimous result was to merge this as it is needed for the malf AI gamemode in the future.

@slarticodefast slarticodefast merged commit 6459f71 into space-wizards:master Sep 25, 2024
12 checks passed
@squirrelanna
Copy link

If the main contention is that pAIs having binary hurts the malf AI in particular, why not have a comms channel that also includes all networked electronic beings and devices? One that can also be more easily accessed by crew members? It feels seriously awful when you get isolated in an RP-based multiplayer game through no control of your own, and having SOME way to communicate at least gives you a chance to stay in the round and have interaction even if you're just lost in space. This will allow binary to become a way for antagonist silicons to communicate and preserve the current functionality of pAIs. Or just allow encryption keys and the ability to speak on those comms.

@VasilisThePikachu
Copy link
Member Author

If the main contention is that pAIs having binary hurts the malf AI in particular, why not have a comms channel that also includes all networked electronic beings and devices? One that can also be more easily accessed by crew members? It feels seriously awful when you get isolated in an RP-based multiplayer game through no control of your own, and having SOME way to communicate at least gives you a chance to stay in the round and have interaction even if you're just lost in space. This will allow binary to become a way for antagonist silicons to communicate and preserve the current functionality of pAIs. Or just allow encryption keys and the ability to speak on those comms.

This is what happens in some ss13 servers from what I was told, but it's not part of this PR. I would not mind seeing a PR adding it

@LordEclipse
Copy link
Member

If the main contention is that pAIs having binary hurts the malf AI in particular, why not have a comms channel that also includes all networked electronic beings and devices? One that can also be more easily accessed by crew members? It feels seriously awful when you get isolated in an RP-based multiplayer game through no control of your own, and having SOME way to communicate at least gives you a chance to stay in the round and have interaction even if you're just lost in space. This will allow binary to become a way for antagonist silicons to communicate and preserve the current functionality of pAIs. Or just allow encryption keys and the ability to speak on those comms.

Isn't that just Common?

@ScarKy0
Copy link
Contributor

ScarKy0 commented Sep 26, 2024

Isn't that just Common?

IIRC pAI etc can't speak on Common?

@slarticodefast
Copy link
Member

slarticodefast commented Sep 26, 2024

IIRC pAI etc can't speak on Common?

For pAI the reason they cannot speak on common is that they should not be able to shout "help, my owner is being attacked" on the radio the moment an antagonist is making a move. This would be very frustrating as an antag if your target has a pAI with them and you try to be stealthy. There have been PRs to give pAIs the ability to speak on common and they have been refused for that reason. And the same thing is a problem with them being able to speak on binary as well.

@LordEclipse
Copy link
Member

Isn't that just Common?

IIRC pAI etc can't speak on Common?

Then let them

@ScarKy0
Copy link
Contributor

ScarKy0 commented Sep 26, 2024

And the same thing is a problem with them being able to speak on binary as well.

pAI gameplay gonna get very boring bros 😭
Chatting with silicons was hella fun

@Welldzhik
Copy link

IIRC pAI etc can't speak on Common?

For pAI the reason they cannot speak on common is that they should not be able to shout "help, my owner is being attacked" on the radio the moment an antagonist is making a move. This would be very frustrating as an antag if your target has a pAI with them and you try to be stealthy. There have been PRs to give pAIs the ability to speak on common and they have been refused for that reason. And the same thing is a problem with them being able to speak on binary as well.

What about just make a communication jammer cheaper? Two times like that. I mean, if you make it available, this problem becomes irrelevant. And not that it could somehow break the balance. Nobody uses it. In my memory, at least. For 4 TK you can buy a full-fledged weapon or tool.

@ArcaneOcto
Copy link

pAI gameplay gonna get very boring bros 😭 Chatting with silicons was hella fun

Hopefully pAIs can get laws later on and get this functionality again🤞
I think all the pAIs turning evil in the case of a malf AI would be sick.

@ArtisticRoomba
Copy link
Contributor

Maybe when we get frequency channels on radios we can have a separate "Widenet" channel for all silicon machines to talk, while keeping "binary" separate for Malf AI purposes. I'd have to look and see what SS13 did in terms of keeping pAIs/borgs separate.

@Lucidueye
Copy link

Lucidueye commented Sep 26, 2024

Malf AI isn't in the game yet (antimov is a lawset not malf ai), as it stands this is just screwing over players. There's practically nothing to do as a pAI without the ability to speak on binary other than be a glorified map and mp3 player.
If you owner is mute or a mime and getting attacked, then there's nothing you can do. You can't get help for them and they can't call for help on their own.
When Malf AI is implented it can have its own channel to use with borgs to prevent spying, or all silicons can be assigned to a different channel as suggested here

@LordEclipse
Copy link
Member

Maybe encryption keys can be slotted into pAIs? I wonder how that would go.

@space-wizards space-wizards locked as too heated and limited conversation to collaborators Sep 26, 2024
@VasilisThePikachu
Copy link
Member Author

Please continue discussion in a development channel on discord or on the forums. Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No C# For things that don't need code. Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.