Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Color for Command Radio #32389

Closed

Conversation

spanky-spanky
Copy link
Contributor

About the PR

Changes color of command radio channel from yellow to blue.

Why / Balance

From a colorblind accessibility standpoint, the current command radio color is incredibly similar to common at a glance for some people (including myself). This makes playing command a bit more difficult as I have to more frequently check for command related radio messages and often end up missing them entirely.

Only issue remaining that should be added to this PR (or fixed later I suppose) is the color used for this chat section when typing, which is independent from radio_channels.yml and I can't find where it's controlled.
image

Media

New color
image
Old Color (and compared to common)
image
Command headset and encryption key aren't yellow anyways so it still fits theme wise.
image

Requirements

Changelog
🆑

  • tweak: Changed command radio color from yellow to blue.

@github-actions github-actions bot added the No C# For things that don't need code. label Sep 22, 2024
@Cojoke-dot
Copy link
Contributor

That's a lot harder to see, I like the yellow because it pops and makes it easier for command members to notice it.

@ArcaneOcto
Copy link

I quite like the old color. As someone who is not colorblind, I think the yellow stands out a lot more (compared to AI announcement or medical radio). Is there a way to make the new color (or the old color) be an option toggleable in the settings?

@spanky-spanky
Copy link
Contributor Author

spanky-spanky commented Sep 22, 2024

and makes it easier for command members to notice it.

Unless you’re colorblind. Would be nice to have radio color tweakable in options but that’s far outside what I can do.

@lzk228
Copy link
Contributor

lzk228 commented Sep 22, 2024

yes i feel like it should be changed, because it's similar with announcements color
or the announcement color or style can be changed

@ArcaneOcto
Copy link

ArcaneOcto commented Sep 22, 2024

yes i feel like it should be changed, because it's similar with announcements color or the announcement color or style can be changed

The announcements color makes sense to be yellow because it's from command. People know it's from command at a glance because of the yellow color. This is why when the AI makes an announcement it is blue, it lets people know it is not from command. Also there just isn't really a good, bright color other than yellow to use. All others are taken by other radio channels.

@slarticodefast
Copy link
Member

If we add a colorblind setting in the game options: Which UIs would generally profit the most from that besides the chat colors? Are there any item sprites that cause problems as well?

@spanky-spanky
Copy link
Contributor Author

If we add a colorblind setting in the game options: Which UIs would generally profit the most from that besides the chat colors? Are there any item sprites that cause problems as well?

There's currently "Colorblind friendly mode" checkbox under Accessibility in options, but having it just be a toggle isn't great when some may want just select changes.

@slarticodefast
Copy link
Member

There's currently "Colorblind friendly mode" checkbox under Accessibility in options, but having it just be a toggle isn't great when some may want just select changes.

Since there are different kinds of colorblindness ideally that would be changed into an options button with different selections I would say. I have to check what that button does at the moment.

@spanky-spanky
Copy link
Contributor Author

I am not opposed to changing the color for common instead but figured that would be a way more controversial discussion. Happy to consider it though if anyone has thoughts.

@spanky-spanky
Copy link
Contributor Author

spanky-spanky commented Sep 22, 2024

Closing this and opening an issue for continued discussion, since it seems this is generally not a liked solution.
#32390 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# For things that don't need code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants