Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a jukebox volume slider #32391

Closed
wants to merge 1 commit into from

Conversation

TGRCdev
Copy link
Contributor

@TGRCdev TGRCdev commented Sep 22, 2024

About the PR

This PR adds a new jukebox volume slider to the options screen. Resolves #27981.

Why / Balance

Technical details

This PR requires a PR in RobustToolbox to allow changing the volume on AudioComponents without marking them as dirty.

Media

jukebox-slider.mp4

Requirements

Breaking changes

Changelog

🆑 TGRCDev

  • add: Jukebox music volume can now be adjusted in the options screen.

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design and removed Status: Needs Review This PR requires new reviews before it can be merged. labels Sep 22, 2024
@TGRCdev TGRCdev marked this pull request as draft September 22, 2024 23:26
@TGRCdev
Copy link
Contributor Author

TGRCdev commented Sep 22, 2024

Damnit I forgot to set it as a draft 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Jukebox volume slider
1 participant