Make chat use messages instead of commands #32400
Open
+189
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectroJr
requested review from
DrSmugleaf and
Chief-Engineer
as code owners
github-actions
bot
added
the
Status: Needs Review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
Merge Conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Changes most most in game chat messages are now sent to the server via a
RequestChatMessageNetMessage, instead of all using commands.Why / Balance
The main motivation for this was to make it easier to filter for commands being executed by players in grafana. Having to constantly filter out all of the various chat "commands" is kind of a pain. Also more future proof if ever chat need to support more than just simple strings.
Media
rider64_JCxuxuy5UQ.mp4
Requirements
Breaking changes
Changelog