fix powered lights electrocuting you despite having insulated gloves #32409
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalgearsloth
added
the
Status: Awaiting Changes
github-actions
bot
added
Status: Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Lights will no longer electrocute you while wearing any gloves with the InsulatedComponent
Why / Balance
i'm guessing that was always the indented behavior but no one implemented it because of how the AttackedEvent works, considering how it checks for the component when interacting
also needed to fix DeltaV-Station/Delta-v#909 downstream
Technical details
Checks for InsulatedComponent on the entity (if for whatever reason it has one), if false, moves on to check the gloves, and adjusts the siemens coefficient accordingly, otherwise defaults to 1.
Requirements
Breaking changes
None
Changelog
🆑