fix paper staying on fire forever #32412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that the same issue as #32081 ? |
Oh yeah I'll link that one too |
|
Thanks for the fix! |
Ilya246
pushed a commit
to Ilya246/space-station-14
that referenced
this pull request
Oct 7, 2024
okay who did that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
what it says on the tin
fixes DeltaV-Station/Delta-v#1325 and #32081
Why / Balance
Paper being able to stay on fire forever, even in vacuum, is just stupid. I think the intention here was that documents being set on fire will always turn to ash but it clearly doesn't work anyways and maybe with a proper FlammableSystem refactor this could be brought back.
Technical details
removes two lines of yaml, canResistFire already defaults to false and canExtinguish to true
Requirements
Breaking changes
no
Changelog
🆑